fix the fake console tests

Author: paulb777

FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h

@@ -29,12 +29,6 @@ NS_ASSUME_NONNULL_BEGIN
 
 @class RCNConfigSettings;
 
-@interface FIRRemoteConfigUpdate ()
-
-/// Designated initializer.
-- (instancetype)initWithUpdatedKeys:(NSSet<NSString *> *)updatedKeys;
-@end
-
 @interface FIRRemoteConfig () {
   NSString *_FIRNamespace;
 }

FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h

@@ -17,6 +17,7 @@
 #import <Foundation/Foundation.h>
 
 @class FIRApp;
+@class FIRRemoteConfigUpdate;
 
 /// The Firebase Remote Config service default namespace, to be used if the API method does not
 /// specify a different namespace. Use the default namespace if configuring from the Google Firebase
@@ -170,19 +171,6 @@ NS_SWIFT_NAME(RemoteConfigSettings)
 @property(nonatomic, assign) NSTimeInterval fetchTimeout;
 @end
 
-#pragma mark - FIRRemoteConfigUpdate
-/// Used by Remote Config real-time config update service, this class represents changes between the
-/// newly fetched config and the current one. An instance of this class is passed to
-/// `FIRRemoteConfigUpdateCompletion` when a new config version has been automatically fetched.
-NS_SWIFT_NAME(RemoteConfigUpdate)
-@interface FIRRemoteConfigUpdate : NSObject
-
-/// Parameter keys whose values have been updated from the currently activated values. Includes
-/// keys that are added, deleted, and whose value, value source, or metadata has changed.
-@property(nonatomic, readonly, nonnull) NSSet<NSString *> *updatedKeys;
-
-@end
-
 #pragma mark - FIRRemoteConfig
 /// Firebase Remote Config class. The class method `remoteConfig()` can be used
 /// to fetch, activate and read config results and set default config results on the default

FirebaseRemoteConfig/Sources/RCNConfigContent.m

@@ -16,6 +16,8 @@
 
 #import "FirebaseRemoteConfig/Sources/RCNConfigContent.h"
 
+#import "FirebaseRemoteConfig/FirebaseRemoteConfig-Swift.h"
+
 #import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
 #import "FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h"
 #import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"

FirebaseRemoteConfig/Sources/RCNConfigRealtime.m

@@ -19,6 +19,7 @@
 #import <GoogleUtilities/GULNSData+zlib.h>
 #import "FirebaseCore/Extension/FirebaseCoreInternal.h"
 #import "FirebaseInstallations/Source/Library/Private/FirebaseInstallationsInternal.h"
+#import "FirebaseRemoteConfig/FirebaseRemoteConfig-Swift.h"
 #import "FirebaseRemoteConfig/Sources/Private/RCNConfigFetch.h"
 #import "FirebaseRemoteConfig/Sources/Private/RCNConfigSettings.h"
 #import "FirebaseRemoteConfig/Sources/RCNConfigConstants.h"
@@ -167,7 +168,7 @@ - (void)propagateErrors:(NSError *)error {
 // TESTING ONLY
 - (void)triggerListenerForTesting:(void (^_Nonnull)(FIRRemoteConfigUpdate *configUpdate,
                                                     NSError *_Nullable error))listener {
-  listener([[FIRRemoteConfigUpdate alloc] init], nil);
+  listener([[FIRRemoteConfigUpdate alloc] initWithUpdatedKeys:[[NSSet alloc] init]], nil);
 }
 
 #pragma mark - Http Helpers

FirebaseRemoteConfig/SwiftNew/RemoteConfigUpdate.swift

@@ -15,14 +15,14 @@
 import Foundation
 
 @objc(FIRRemoteConfigUpdate)
-class RemoteConfigUpdate: NSObject {
+public class RemoteConfigUpdate: NSObject {
   private let _updatedKeys: Set<String>
 
-  @objc init(updatedKeys: Set<String>) {
+  @objc public init(updatedKeys: Set<String>) {
     _updatedKeys = updatedKeys
   }
 
-  @objc var updatedKeys: Set<String> {
+  @objc public var updatedKeys: Set<String> {
     return _updatedKeys
   }
 }

FirebaseRemoteConfig/Tests/Swift/SwiftAPI/FirebaseRemoteConfigSwift_APIBuildTests.swift

@@ -107,7 +107,7 @@ final class FirebaseRemoteConfig_APIBuildTests: XCTestCase {
     settings.fetchTimeout = TimeInterval(100)
 
     // TODO(ncooke3): This should probably not be initializable.
-    let update = FirebaseRemoteConfig.RemoteConfigUpdate()
+    let update = FirebaseRemoteConfig.RemoteConfigUpdate(updatedKeys: Set<String>())
     let _: Set<String> = update.updatedKeys
 
     let _ = FirebaseRemoteConfig.RemoteConfig.remoteConfig()