Allow list() at root (#5772)

Author: schmidt-sebastian

FirebaseStorage/CHANGELOG.md

@@ -1,4 +1,5 @@
 # Unreleased
+- [fixed] Fixed a crash when listAll() was called at the root location. (#5772)
 
 # 3.6.1
 - [fixed] Fix a rare case where a StorageTask would call its completion callbacks more than

FirebaseStorage/Sources/FIRStorageListResult.m

@@ -33,16 +33,12 @@ + (nullable FIRStorageListResult *)fromDictionary:(NSDictionary<NSString *, id>
     }
 
     FIRStorageReference *prefixReference = [rootReference child:pathWithoutTrailingSlash];
-    NSAssert([prefixReference.fullPath hasPrefix:reference.fullPath],
-             @"Expected %@ to be a child element of %@", reference, prefixReference);
     [prefixes addObject:prefixReference];
   }
 
   NSArray<NSDictionary<NSString *, NSString *> *> *itemEntries = dictionary[kFIRStorageListItems];
   for (NSDictionary<NSString *, NSString *> *itemEntry in itemEntries) {
     FIRStorageReference *itemReference = [rootReference child:itemEntry[kFIRStorageListItemName]];
-    NSAssert([itemReference.fullPath hasPrefix:reference.fullPath],
-             @"Expected %@ to be a child element of %@", reference, itemReference);
     [items addObject:itemReference];
   }
 

FirebaseStorage/Tests/Integration/FIRStorageIntegrationTests.m

@@ -30,6 +30,9 @@
   rules_version = '2';
   service firebase.storage {
     match /b/{bucket}/o {
+      match /{directChild=*} {
+        allow read: if request.auth != null;
+      }
       match /ios {
         match /public/{allPaths=**} {
           allow write: if request.auth != null;
@@ -767,7 +770,7 @@ - (void)testPagedListFiles {
 }
 
 - (void)testListAllFiles {
-  XCTestExpectation *expectation = [self expectationWithDescription:@"testPagedListFiles"];
+  XCTestExpectation *expectation = [self expectationWithDescription:@"testListAllFiles"];
 
   FIRStorageReference *ref = [self.storage referenceWithPath:@"ios/public/list"];
 
@@ -786,6 +789,22 @@ - (void)testListAllFiles {
   [self waitForExpectations];
 }
 
+- (void)testListFilesAtRoot {
+  XCTestExpectation *expectation = [self expectationWithDescription:@"testListFilesAtRoot"];
+
+  FIRStorageReference *ref = [self.storage referenceWithPath:@""];
+
+  [ref listAllWithCompletion:^(FIRStorageListResult *_Nullable listResult,
+                               NSError *_Nullable error) {
+    XCTAssertNotNil(listResult);
+    XCTAssertNil(error);
+    XCTAssertNil(listResult.pageToken);
+    [expectation fulfill];
+  }];
+
+  [self waitForExpectations];
+}
+
 - (void)waitForExpectations {
   [self waitForExpectationsWithTimeout:kFIRStorageIntegrationTestTimeout
                                handler:^(NSError *_Nullable error) {