Performance Improvements - Move Some Initialization Work to a Background Thread (#7332)

Author: elenadoty

Crashlytics/CHANGELOG.md

@@ -1,4 +1,5 @@
 # Unreleased
+- [changed] Improve start-up performance by moving some initialization work to a background thread (#7332).
 - [changed] Updated upload-symbols to a version that is notarized to avoid macOS security alerts (#7323).
 
 # v7.4.0

Crashlytics/Crashlytics/Components/FIRCLSBinaryImage.m

@@ -364,19 +364,18 @@ static void FIRCLSBinaryImageChanged(bool added,
                                      intptr_t vmaddr_slide) {
   //    FIRCLSSDKLog("Binary image %s %p\n", added ? "loaded" : "unloaded", mh);
 
-  FIRCLSBinaryImageDetails imageDetails;
-
-  memset(&imageDetails, 0, sizeof(FIRCLSBinaryImageDetails));
+  // this isn't, so do it on a serial queue
+  dispatch_async(FIRCLSGetBinaryImageQueue(), ^{
+    FIRCLSBinaryImageDetails imageDetails;
 
-  imageDetails.slice = FIRCLSMachOSliceWithHeader((void*)mh);
-  imageDetails.vmaddr_slide = vmaddr_slide;
-  FIRCLSBinaryImageFillInImageDetails(&imageDetails);
+    memset(&imageDetails, 0, sizeof(FIRCLSBinaryImageDetails));
 
-  // this is an atomic operation
-  FIRCLSBinaryImageStoreNode(added, imageDetails);
+    imageDetails.slice = FIRCLSMachOSliceWithHeader((void*)mh);
+    imageDetails.vmaddr_slide = vmaddr_slide;
+    FIRCLSBinaryImageFillInImageDetails(&imageDetails);
 
-  // this isn't, so do it on a serial queue
-  dispatch_async(FIRCLSGetBinaryImageQueue(), ^{
+    // this is an atomic operation
+    FIRCLSBinaryImageStoreNode(added, imageDetails);
     FIRCLSBinaryImageRecordSlice(added, imageDetails);
   });
 }