Skip to content

Commit 93574c5

Browse files
authored
Update coverage workflow (#7430)
* Trigger a workflow when a pr is created. * Remove redundant comments and update variables.
1 parent f3bb73f commit 93574c5

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/workflows/test_coverage.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ name: test_coverage
22

33
on:
44
pull_request:
5+
# open will be triggered when a pull request is created.
56
# synchronize will be triggered when a pull request has new commits.
67
# closed will be triggered when a pull request is closed.
7-
types: [synchronize, closed]
8+
types: [open, synchronize, closed]
89

910
jobs:
1011
check:

scripts/code_coverage_report/generate_code_coverage_report/Sources/CoverageReportGenerator/CoverageReportParser.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ extension CoverageReportRequestData {
6666
// FirebaseDatabase-ios-FirebaseCore.framework, a regex pattern will be
6767
// used to exclude results that are not related in terms of the target names.
6868
let sdk_name = resultBundle.components(separatedBy: "-")[0]
69-
let range = NSRange(location: 0, length: sdk_name.utf16.count)
69+
let range = NSRange(location: 0, length: target.name.utf16.count)
7070
let sdk_related_coverage_file_pattern = try! NSRegularExpression(
7171
pattern: ".*\(sdk_name).*",
7272
options: NSRegularExpression.Options(rawValue: 0)
@@ -78,8 +78,6 @@ extension CoverageReportRequestData {
7878
value: target.lineCoverage))
7979
for file in target.files {
8080
results
81-
// .append(FileCoverage(sdk: resultBundle + "-" + target.name + "(Coverage:\(String(format:"%.2f%%", target.lineCoverage*100)))", type: file.name,
82-
// value: file.lineCoverage))
8381
.append(FileCoverage(sdk: resultBundle + "-" + target.name, type: file.name,
8482
value: file.lineCoverage))
8583
results

0 commit comments

Comments
 (0)