Storage Integration Tests to Swift (#5197)

Author: paulb777

FirebaseStorage.podspec

@@ -53,4 +53,12 @@ Firebase Storage provides robust, secure file uploads and downloads from Firebas
     int_tests.resources = 'FirebaseStorage/Tests/Integration/Resources/1mb.dat',
                           'FirebaseStorage/Tests/Integration/Resources/GoogleService-Info.plist'
   end
+
+  s.test_spec 'swift-integration' do |swift_int_tests|
+    swift_int_tests.platforms = {:ios => '8.0', :osx => '10.11', :tvos => '10.0'}
+    swift_int_tests.source_files = 'FirebaseStorage/Tests/SwiftIntegration/*.swift'
+    swift_int_tests.requires_app_host = true
+    swift_int_tests.resources = 'FirebaseStorage/Tests/Integration/Resources/1mb.dat',
+                          'FirebaseStorage/Tests/Integration/Resources/GoogleService-Info.plist'
+  end
 end

FirebaseStorage/Tests/Integration/FIRStorageIntegrationTests.m

@@ -496,7 +496,7 @@ - (void)testUnauthenticatedSimpleGetDownloadURL {
 
 - (void)testUnauthenticatedSimpleGetFile {
   XCTestExpectation *expectation =
-      [self expectationWithDescription:@"testUnauthenticatedSimpleGetData"];
+      [self expectationWithDescription:@"testUnauthenticatedSimpleGetFile"];
 
   FIRStorageReference *ref = [self.storage referenceWithPath:@"ios/public/helloworld"];
 
@@ -529,7 +529,6 @@ - (void)testUnauthenticatedSimpleGetFile {
         [task observeStatus:FIRStorageTaskStatusFailure
                     handler:^(FIRStorageTaskSnapshot *snapshot) {
                       XCTAssertNil(snapshot.error);
-                      [expectation fulfill];
                     }];
       }];
 
@@ -583,9 +582,7 @@ - (void)assertMetadataNil:(FIRStorageMetadata *)actualMetadata {
   XCTAssertNil(actualMetadata.contentLanguage);
   XCTAssertNil(actualMetadata.contentType);
   XCTAssertTrue([actualMetadata.md5Hash length] == 24);
-  XCTAssertNil([actualMetadata.customMetadata objectForKey:@"a"]);
-  XCTAssertNil([actualMetadata.customMetadata objectForKey:@"c"]);
-  XCTAssertNil([actualMetadata.customMetadata objectForKey:@"f"]);
+  XCTAssertNil(actualMetadata.customMetadata);
 }
 
 - (void)testUpdateMetadata {