Skip to content

Commit 956059d

Browse files
authored
Disable resource management for binary pods (#8802)
1 parent 874f2ce commit 956059d

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

ReleaseTooling/Sources/ZipBuilder/ZipBuilder.swift

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -808,13 +808,15 @@ struct ZipBuilder {
808808
}
809809
var frameworks: [URL] = []
810810

811+
// TODO: packageAllResources is disabled for binary frameworks since it's not needed for Firebase
812+
// and it does not yet support xcframeworks.
811813
// Package all resources into the frameworks since that's how Carthage needs it packaged.
812-
do {
813-
// TODO: Figure out if we need to exclude bundles here or not.
814-
try ResourcesManager.packageAllResources(containedIn: podInfo.installedLocation)
815-
} catch {
816-
fatalError("Tried to package resources for \(podName) but it failed: \(error)")
817-
}
814+
// do {
815+
// // TODO: Figure out if we need to exclude bundles here or not.
816+
// try ResourcesManager.packageAllResources(containedIn: podInfo.installedLocation)
817+
// } catch {
818+
// fatalError("Tried to package resources for \(podName) but it failed: \(error)")
819+
// }
818820

819821
// Copy each of the frameworks to a known temporary directory and store the location.
820822
for framework in podInfo.binaryFrameworks {

0 commit comments

Comments
 (0)