Skip to content

Commit 959cf0d

Browse files
authored
Fix compile errors in Combine (#11610)
#11231 introduces some renamed methods, which broke the Combine build, see this workflow run: firebase/firebase-ios-sdk/actions/runs/5665691823 This PR should fix this.
1 parent 00dad35 commit 959cf0d

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

FirebaseCombineSwift/Tests/Unit/Auth/AuthMocks.swift

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,17 @@ extension AuthBackendImplementationMock {
104104
fatalError("You need to implement \(#function) in your mock.")
105105
}
106106

107+
func getRecaptchaConfig(_ request: FIRGetRecaptchaConfigRequest,
108+
callback: @escaping FIRGetRecaptchaConfigResponseCallback) {
109+
fatalError("You need to implement \(#function) in your mock.")
110+
}
111+
107112
func resetPassword(_ request: FIRResetPasswordRequest,
108113
callback: @escaping FIRResetPasswordCallback) {
109114
fatalError("You need to implement \(#function) in your mock.")
110115
}
111116

112-
func post(with request: FIRAuthRPCRequest, response: FIRAuthRPCResponse,
117+
func call(with request: FIRAuthRPCRequest, response: FIRAuthRPCResponse,
113118
callback: @escaping (Error?) -> Void) {
114119
fatalError("You need to implement \(#function) in your mock.")
115120
}

FirebaseCombineSwift/Tests/Unit/Auth/SignInWithGameCenterTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class SignInWithGameCenterTests: XCTestCase {
6969
var contentType: String?
7070
var handler: FIRAuthBackendRPCIssuerCompletionHandler?
7171

72-
func asyncPostToURL(with requestConfiguration: FIRAuthRequestConfiguration, url URL: URL,
72+
func asyncCallToURL(with requestConfiguration: FIRAuthRequestConfiguration, url URL: URL,
7373
body: Data?, contentType: String,
7474
completionHandler handler: @escaping FIRAuthBackendRPCIssuerCompletionHandler) {
7575
requestURL = URL

FirebaseCombineSwift/Tests/Unit/FirebaseCombine-unit-Bridging-Header.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetOOBConfirmationCodeResponse.h"
4343
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetProjectConfigRequest.h"
4444
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetProjectConfigResponse.h"
45+
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetRecaptchaConfigRequest.h"
46+
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetRecaptchaConfigResponse.h"
4547
#import "FirebaseAuth/Sources/Backend/RPC/FIRResetPasswordRequest.h"
4648
#import "FirebaseAuth/Sources/Backend/RPC/FIRResetPasswordResponse.h"
4749
#import "FirebaseAuth/Sources/Backend/RPC/FIRRevokeTokenRequest.h"

0 commit comments

Comments
 (0)