Skip to content

Commit 98a3baf

Browse files
authored
Move Dynamic Links to API_UNAVAILABLE (#8467)
* Move Dynamic Links to API_UNAVAILABLE * Add changelog
1 parent 78ef3c8 commit 98a3baf

File tree

3 files changed

+16
-26
lines changed

3 files changed

+16
-26
lines changed

FirebaseDynamicLinks/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# v8.6.0
2+
- [changed] Replaced conditionally-compiled APIs with `API_UNAVAILABLE` annotations on unsupported platforms (#8467).
3+
14
# v8.4.0
25
- [fixed] Fixed build issues introduced in Xcode 13 beta 3. (#8401)
36
- [fixed] Fixed build failures for extension targets. (#6548)

FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FDLURLComponents.h

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,6 @@
1616

1717
#import <Foundation/Foundation.h>
1818

19-
// NS_SWIFT_NAME can only translate factory methods before the iOS 9.3 SDK.
20-
// Wrap it in our own macro if it's a non-compatible SDK.
21-
#ifndef FIR_SWIFT_NAME
22-
#ifdef __IPHONE_9_3
23-
#define FIR_SWIFT_NAME(X) NS_SWIFT_NAME(X)
24-
#else
25-
#define FIR_SWIFT_NAME(X) // Intentionally blank.
26-
#endif // #ifdef __IPHONE_9_3
27-
#endif // #ifndef FIR_SWIFT_NAME
28-
2919
NS_ASSUME_NONNULL_BEGIN
3020

3121
/**
@@ -40,7 +30,7 @@ typedef NS_ENUM(NSInteger, FIRShortDynamicLinkPathLength) {
4030
FIRShortDynamicLinkPathLengthShort,
4131
/** Short link with an extra long path for great difficulty in guessing. */
4232
FIRShortDynamicLinkPathLengthUnguessable,
43-
} FIR_SWIFT_NAME(ShortDynamicLinkPathLength);
33+
} NS_SWIFT_NAME(ShortDynamicLinkPathLength);
4434

4535
/**
4636
* @abstract The definition of the completion block used by URL shortener.
@@ -53,13 +43,13 @@ typedef NS_ENUM(NSInteger, FIRShortDynamicLinkPathLength) {
5343
typedef void (^FIRDynamicLinkShortenerCompletion)(NSURL *_Nullable shortURL,
5444
NSArray<NSString *> *_Nullable warnings,
5545
NSError *_Nullable error)
56-
FIR_SWIFT_NAME(DynamicLinkShortenerCompletion);
46+
NS_SWIFT_NAME(DynamicLinkShortenerCompletion);
5747

5848
/**
5949
* @class FIRDynamicLinkGoogleAnalyticsParameters
6050
* @abstract The Dynamic Link analytics parameters.
6151
*/
62-
FIR_SWIFT_NAME(DynamicLinkGoogleAnalyticsParameters)
52+
NS_SWIFT_NAME(DynamicLinkGoogleAnalyticsParameters)
6353
@interface FIRDynamicLinkGoogleAnalyticsParameters : NSObject
6454

6555
/**
@@ -138,7 +128,7 @@ FIR_SWIFT_NAME(DynamicLinkGoogleAnalyticsParameters)
138128
* @class FIRDynamicLinkIOSParameters
139129
* @abstract The Dynamic Link iOS parameters.
140130
*/
141-
FIR_SWIFT_NAME(DynamicLinkIOSParameters)
131+
NS_SWIFT_NAME(DynamicLinkIOSParameters)
142132
@interface FIRDynamicLinkIOSParameters : NSObject
143133

144134
/**
@@ -214,7 +204,7 @@ FIR_SWIFT_NAME(DynamicLinkIOSParameters)
214204
* @class FIRDynamicLinkItunesConnectAnalyticsParameters
215205
* @abstract The Dynamic Link iTunes Connect parameters.
216206
*/
217-
FIR_SWIFT_NAME(DynamicLinkItunesConnectAnalyticsParameters)
207+
NS_SWIFT_NAME(DynamicLinkItunesConnectAnalyticsParameters)
218208
@interface FIRDynamicLinkItunesConnectAnalyticsParameters : NSObject
219209

220210
/**
@@ -255,7 +245,7 @@ FIR_SWIFT_NAME(DynamicLinkItunesConnectAnalyticsParameters)
255245
* @class FIRDynamicLinkAndroidParameters
256246
* @abstract The Dynamic Link Android parameters.
257247
*/
258-
FIR_SWIFT_NAME(DynamicLinkAndroidParameters)
248+
NS_SWIFT_NAME(DynamicLinkAndroidParameters)
259249
@interface FIRDynamicLinkAndroidParameters : NSObject
260250

261251
/**
@@ -303,7 +293,7 @@ FIR_SWIFT_NAME(DynamicLinkAndroidParameters)
303293
* @class FIRDynamicLinkSocialMetaTagParameters
304294
* @abstract The Dynamic Link Social Meta Tag parameters.
305295
*/
306-
FIR_SWIFT_NAME(DynamicLinkSocialMetaTagParameters)
296+
NS_SWIFT_NAME(DynamicLinkSocialMetaTagParameters)
307297
@interface FIRDynamicLinkSocialMetaTagParameters : NSObject
308298

309299
/**
@@ -344,7 +334,7 @@ FIR_SWIFT_NAME(DynamicLinkSocialMetaTagParameters)
344334
* @class FIRDynamicLinkNavigationInfoParameters
345335
* @abstract Options class for defining navigation behavior of the Dynamic Link.
346336
*/
347-
FIR_SWIFT_NAME(DynamicLinkNavigationInfoParameters)
337+
NS_SWIFT_NAME(DynamicLinkNavigationInfoParameters)
348338
@interface FIRDynamicLinkNavigationInfoParameters : NSObject
349339

350340
/**
@@ -379,7 +369,7 @@ FIR_SWIFT_NAME(DynamicLinkNavigationInfoParameters)
379369
* @abstract Options class for defining other platform(s) parameters of the Dynamic Link.
380370
* Other here means not covered by specific parameters (not iOS and not Android).
381371
*/
382-
FIR_SWIFT_NAME(DynamicLinkOtherPlatformParameters)
372+
NS_SWIFT_NAME(DynamicLinkOtherPlatformParameters)
383373
@interface FIRDynamicLinkOtherPlatformParameters : NSObject
384374

385375
/**
@@ -411,7 +401,7 @@ FIR_SWIFT_NAME(DynamicLinkOtherPlatformParameters)
411401
* @class FIRDynamicLinkComponentsOptions
412402
* @abstract Options class for defining how Dynamic Link URLs are generated.
413403
*/
414-
FIR_SWIFT_NAME(DynamicLinkComponentsOptions)
404+
NS_SWIFT_NAME(DynamicLinkComponentsOptions)
415405
@interface FIRDynamicLinkComponentsOptions : NSObject
416406

417407
/**
@@ -444,7 +434,7 @@ FIR_SWIFT_NAME(DynamicLinkComponentsOptions)
444434
* Dynamic Link URLs. Short URLs will have a domain and a randomized path; long URLs will have a
445435
* domain and a query that contains all of the Dynamic Link parameters.
446436
*/
447-
FIR_SWIFT_NAME(DynamicLinkComponents)
437+
NS_SWIFT_NAME(DynamicLinkComponents)
448438
@interface FIRDynamicLinkComponents : NSObject
449439

450440
/**

FirebaseDynamicLinks/Sources/Public/FirebaseDynamicLinks/FIRDynamicLinks.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
#import <Foundation/Foundation.h>
1818

19-
#import <TargetConditionals.h>
20-
#if TARGET_OS_IOS
21-
2219
#import "FIRDynamicLink.h"
2320
#import "FIRDynamicLinksCommon.h"
2421

@@ -32,9 +29,11 @@ NS_ASSUME_NONNULL_BEGIN
3229
/**
3330
* @class FIRDynamicLinks
3431
* @abstract A class that checks for pending Dynamic Links and parses URLs.
32+
* This class is available on iOS only.
3533
*/
3634

3735
NS_EXTENSION_UNAVAILABLE_IOS("Firebase Dynamic Links is not supported for iOS extensions.")
36+
API_UNAVAILABLE(macos, tvos, watchos)
3837
NS_SWIFT_NAME(DynamicLinks)
3938
@interface FIRDynamicLinks : NSObject
4039

@@ -141,5 +140,3 @@ NS_SWIFT_NAME(DynamicLinks)
141140
@end
142141

143142
NS_ASSUME_NONNULL_END
144-
145-
#endif

0 commit comments

Comments
 (0)