Not sending messages to closed websocket connections (#99)

schmidt-sebastian · web-flow · commit 9917869191ec · 2017-06-22T14:30:56.000-07:00
I believe this should be a safe change since the timer function nop is only ever run after the websocket is initialized. This works around potential issues in the websocket layer after we close the connection and hopefully addresses https://b.corp.google.com/issues/62363018x
diff --git a/Firebase/Database/Realtime/FWebSocketConnection.m b/Firebase/Database/Realtime/FWebSocketConnection.m
@@ -163,7 +163,7 @@ - (void) send:(NSDictionary *)dictionary {
 }
 
 - (void) nop:(NSTimer *)timer {
-    if(self.webSocket) {
+    if (!isClosed) {
         FFLog(@"I-RDB083004", @"(wsc:%@) nop", self.connectionId);
         [self.webSocket send:@"0"];        
     }

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ - (void) send:(NSDictionary *)dictionary {`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`- (void) nop:(NSTimer *)timer {`
`166`		`- if(self.webSocket) {`
	`166`	`+ if (!isClosed) {`
`167`	`167`	`FFLog(@"I-RDB083004", @"(wsc:%@) nop", self.connectionId);`
`168`	`168`	`[self.webSocket send:@"0"];`
`169`	`169`	`}`