[Infra] Move 'mlmodeldownloader' workflow to Xcode 16 (#14692)

Author: ncooke3

.github/workflows/mlmodeldownloader.yml

@@ -25,7 +25,7 @@ jobs:
         target: [ios, tvos, macos, watchos]
         build-env:
           - os: macos-14
-            xcode: Xcode_15.2
+            xcode: Xcode_16.2
           - os: macos-15
             xcode: Xcode_16.2
     runs-on: ${{ matrix.build-env.os }}
@@ -48,7 +48,7 @@ jobs:
 
   mlmodeldownloader-cron-only:
     if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
-    runs-on: macos-14
+    runs-on: macos-15
     env:
       plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
     strategy:
@@ -58,6 +58,8 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
+    - name: Xcode
+      run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
     - name: Setup Bundler
       run: scripts/setup_bundler.sh
     - name: Configure test keychain
@@ -78,6 +80,8 @@ jobs:
       cache_key: ${{ steps.generate_cache_key.outputs.cache_key }}
     steps:
       - uses: actions/checkout@v4
+      - name: Xcode
+        run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
       - name: Generate Swift Package.resolved
         id: swift_package_resolve
         run: |
@@ -99,11 +103,8 @@ jobs:
     strategy:
       matrix:
         include:
-          - os: macos-13
-            xcode: Xcode_15.2
-            target: iOS
           - os: macos-14
-            xcode: Xcode_15.4
+            xcode: Xcode_16.2
             target: iOS
           - os: macos-15
             xcode: Xcode_16.2
@@ -161,13 +162,15 @@ jobs:
     if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event_name == 'schedule' || github.event_name == 'pull_request')
     env:
       plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
-    runs-on: macos-14
+    runs-on: macos-15
     steps:
     - uses: actions/checkout@v4
     - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
       with:
         cache_key: build-test${{ matrix.os }}
     - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
+    - name: Xcode
+      run: sudo xcode-select -s /Applications/Xcode_16.2.app/Contents/Developer
     - name: Setup Bundler
       run: scripts/setup_bundler.sh
     - name: Install GoogleService-Info.plist

FirebaseMLModelDownloader/Sources/DeviceLogger.swift

@@ -14,7 +14,7 @@
 
 import Foundation
 
-@_implementationOnly import FirebaseCoreExtension
+internal import FirebaseCoreExtension
 
 /// Enum of log messages.
 enum LoggerMessageCode: Int {

FirebaseMLModelDownloader/Sources/DownloaderUserDefaults.swift

@@ -14,9 +14,9 @@
 
 import Foundation
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_UserDefaults
+  internal import GoogleUtilities_UserDefaults
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 /// Protocol to save or delete model info in user defaults.

FirebaseMLModelDownloader/Sources/LocalModelInfo.swift

@@ -14,9 +14,9 @@
 
 import Foundation
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_UserDefaults
+  internal import GoogleUtilities_UserDefaults
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 /// Model info object with details about downloaded and locally available model.

FirebaseMLModelDownloader/Sources/ModelDownloadTask.swift

@@ -14,9 +14,9 @@
 
 import Foundation
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_UserDefaults
+  internal import GoogleUtilities_UserDefaults
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 /// Task to download model file to device.

FirebaseMLModelDownloader/Sources/ModelDownloader.swift

@@ -16,9 +16,9 @@ import FirebaseCore
 import FirebaseInstallations
 import Foundation
 #if SWIFT_PACKAGE
-  @_implementationOnly import GoogleUtilities_UserDefaults
+  internal import GoogleUtilities_UserDefaults
 #else
-  @_implementationOnly import GoogleUtilities
+  internal import GoogleUtilities
 #endif // SWIFT_PACKAGE
 
 /// Possible ways to get a custom model.

FirebaseMLModelDownloader/Tests/Integration/ModelDownloaderIntegrationTests.swift

@@ -23,9 +23,9 @@
   @testable import FirebaseMLModelDownloader
   import XCTest
   #if SWIFT_PACKAGE
-    @_implementationOnly import GoogleUtilities_UserDefaults
+    internal import GoogleUtilities_UserDefaults
   #else
-    @_implementationOnly import GoogleUtilities
+    internal import GoogleUtilities
   #endif // SWIFT_PACKAGE
 
   extension GULUserDefaults {

FirebaseMLModelDownloader/Tests/Unit/ModelDownloaderUnitTests.swift

@@ -23,9 +23,9 @@
   @testable import FirebaseMLModelDownloader
   import XCTest
   #if SWIFT_PACKAGE
-    @_implementationOnly import GoogleUtilities_UserDefaults
+    internal import GoogleUtilities_UserDefaults
   #else
-    @_implementationOnly import GoogleUtilities
+    internal import GoogleUtilities
   #endif // SWIFT_PACKAGE
 
   /// Mock options to configure default Firebase app.