Remove flaky retain count checking (#3065)

* Remove flaky retain count checking
* Disable test

Author: paulb777

Example/InstanceID/Tests/FIRInstanceIDKeyPairMigrationTest.m

@@ -139,6 +139,8 @@ - (void)testMigrationIfLegacyKeyPairsExist {
   [self waitForExpectationsWithTimeout:1 handler:nil];
 }
 
+// Disabling test for now. We need to find a flake free way to insure the publicKeyRef is retained.
+#ifdef DISABLED
 - (void)testUpdateKeyRefWithTagRetainsAndReleasesKeyRef {
   SecKeyRef publicKeyRef;
 
@@ -154,31 +156,16 @@ - (void)testUpdateKeyRefWithTagRetainsAndReleasesKeyRef {
 
     publicKeyRef = keyPair.publicKey;
 
-    // Retain to keep publicKeyRef alive to verify its reatin count
-    CFRetain(publicKeyRef);
-
-    // 2 = 1 from keyPair + 1 from CFRetain()
-    XCTAssertEqual(CFGetRetainCount(publicKeyRef), 2);
-
-    XCTestExpectation *completionExpectaion =
-        [self expectationWithDescription:@"completionExpectaion"];
+    XCTestExpectation *completionExpectation =
+        [self expectationWithDescription:@"completionExpectation"];
     [self.keyPairStore updateKeyRef:keyPair.publicKey
                             withTag:@"test"
                             handler:^(NSError *error) {
-                              [completionExpectaion fulfill];
+                              [completionExpectation fulfill];
                             }];
-
-    // 3 = from keyPair + 1 from CFRetain() + 1 retained by `updateKeyRef`
-    XCTAssertEqual(CFGetRetainCount(publicKeyRef), 3);
   }
-
-  // 2 = 1 from CFRetain() + 1 retained by `updateKeyRef`
-  XCTAssertEqual(CFGetRetainCount(publicKeyRef), 2);
-
   [self waitForExpectationsWithTimeout:0.5 handler:NULL];
-
-  // No one else owns publicKeyRef except the test
-  XCTAssertEqual(CFGetRetainCount(publicKeyRef), 1);
 }
+#endif
 
 @end