Enable lint for Auth (#5097)

Author: renkelvin

Example/Auth/ApiTests/AccountInfoTests.m

@@ -43,20 +43,20 @@ - (void)testUpdatingUsersEmail {
   [auth createUserWithEmail:kOldUserEmail
                    password:@"password"
                  completion:^(FIRAuthDataResult *user, NSError *error) {
-    if (error.code != FIRAuthErrorCodeEmailAlreadyInUse) {
-      apiError = error;
-    }
-    [expectation fulfill];
-  }];
+                   if (error.code != FIRAuthErrorCodeEmailAlreadyInUse) {
+                     apiError = error;
+                   }
+                   [expectation fulfill];
+                 }];
   [self waitForExpectationsWithTimeout:kExpectationsTimeout handler:nil];
 
   expectation = [self expectationWithDescription:@"Sign in with email and password."];
   [auth signInWithEmail:kOldUserEmail
                password:@"password"
-             completion:^(FIRAuthDataResult * _Nullable authResult, NSError * _Nullable error) {
-    apiError = error;
-    [expectation fulfill];
-  }];
+             completion:^(FIRAuthDataResult *_Nullable authResult, NSError *_Nullable error) {
+               apiError = error;
+               [expectation fulfill];
+             }];
   [self waitForExpectationsWithTimeout:kExpectationsTimeout handler:nil];
 
   XCTAssertEqualObjects(auth.currentUser.email, kOldUserEmail);

Example/Auth/ApiTests/FIRAuthApiTestsBase.m

@@ -34,8 +34,7 @@ - (void)signInAnonymously {
     XCTFail(@"Could not obtain auth object.");
   }
 
-  XCTestExpectation *expectation =
-      [self expectationWithDescription:@"Anonymous sign-in finished."];
+  XCTestExpectation *expectation = [self expectationWithDescription:@"Anonymous sign-in finished."];
   [auth signInAnonymouslyWithCompletion:^(FIRAuthDataResult *result, NSError *error) {
     if (error) {
       NSLog(@"Anonymous sign in error: %@", error);

Example/Auth/ApiTests/PhoneMultiFactorTests.swift

@@ -27,53 +27,54 @@ let kOneSecondFactorUserEmail = "[email protected]"
 let kOneSecondFactorUserPassword = "aaaaaa"
 
 class PhoneMultiFactorTests: FIRAuthApiTestsBase {
-
   func testEnrollUnenroll() {
-    let enrollExpectation = self.expectation(description: "Enroll phone multi factor finished.")
-    let unenrollExpectation = self.expectation(description: "Unenroll phone multi factor finished.")
-    Auth.auth().signIn(withEmail: kNoSecondFactorUserEmail, password: kNoSecondFactorUserPassword) { (result, error) in
+    let enrollExpectation = expectation(description: "Enroll phone multi factor finished.")
+    let unenrollExpectation = expectation(description: "Unenroll phone multi factor finished.")
+    Auth.auth().signIn(withEmail: kNoSecondFactorUserEmail, password: kNoSecondFactorUserPassword) { result, error in
       XCTAssertNil(error, "User normal sign in failed. Error: \(error!.localizedDescription)")
 
       // Enroll
       guard let user = result?.user else {
         XCTFail("No valid user after attempted sign-in.")
       }
-      user.multiFactor.getSessionWithCompletion({ (session, error) in
+      user.multiFactor.getSessionWithCompletion { session, error in
         XCTAssertNil(error, "Get multi factor session failed. Error: \(error!.localizedDescription)")
         PhoneAuthProvider.provider().verifyPhoneNumber(
           kPhoneSecondFactorPhoneNumber,
           uiDelegate: nil,
-          multiFactorSession: session) { (verificationId, error) in
-            XCTAssertNil(error, "Verify phone number failed. Error: \(error!.localizedDescription)")
-            let credential = PhoneAuthProvider.provider().credential(
-              withVerificationID: verificationId!,
-              verificationCode: kPhoneSecondFactorVerificationCode)
-            let assertion = PhoneMultiFactorGenerator.assertion(with: credential);
-            user?.multiFactor.enroll(with: assertion, displayName: kPhoneSecondFactorDisplayName) { (error) in
-              XCTAssertNil(error, "Phone multi factor enroll failed. Error: \(error!.localizedDescription)")
-              XCTAssertEqual(Auth.auth().currentUser?.multiFactor.enrolledFactors.first?.displayName, kPhoneSecondFactorDisplayName)
-              enrollExpectation.fulfill()
+          multiFactorSession: session
+        ) { verificationId, error in
+          XCTAssertNil(error, "Verify phone number failed. Error: \(error!.localizedDescription)")
+          let credential = PhoneAuthProvider.provider().credential(
+            withVerificationID: verificationId!,
+            verificationCode: kPhoneSecondFactorVerificationCode
+          )
+          let assertion = PhoneMultiFactorGenerator.assertion(with: credential)
+          user?.multiFactor.enroll(with: assertion, displayName: kPhoneSecondFactorDisplayName) { error in
+            XCTAssertNil(error, "Phone multi factor enroll failed. Error: \(error!.localizedDescription)")
+            XCTAssertEqual(Auth.auth().currentUser?.multiFactor.enrolledFactors.first?.displayName, kPhoneSecondFactorDisplayName)
+            enrollExpectation.fulfill()
 
-              // Unenroll
-              user = Auth.auth().currentUser
-              user?.multiFactor.unenroll(with: (user?.multiFactor.enrolledFactors.first)!, completion: { (error) in
-                XCTAssertNil(error, "Phone multi factor unenroll failed. Error: \(error!.localizedDescription)")
-                XCTAssertEqual(Auth.auth().currentUser?.multiFactor.enrolledFactors.count, 0)
-                unenrollExpectation.fulfill()
-              })
-            }
+            // Unenroll
+            user = Auth.auth().currentUser
+            user?.multiFactor.unenroll(with: (user?.multiFactor.enrolledFactors.first)!, completion: { error in
+              XCTAssertNil(error, "Phone multi factor unenroll failed. Error: \(error!.localizedDescription)")
+              XCTAssertEqual(Auth.auth().currentUser?.multiFactor.enrolledFactors.count, 0)
+              unenrollExpectation.fulfill()
+            })
+          }
         }
-      })
+      }
     }
 
-    self.waitForExpectations(timeout: 30) { error in
+    waitForExpectations(timeout: 30) { error in
       XCTAssertNil(error, "Failed to wait for enroll and unenroll phone multi factor finished. Error: \(error!.localizedDescription)")
     }
   }
 
   func testSignInWithSecondFactor() {
-    let signInExpectation = self.expectation(description: "Sign in with phone multi factor finished.")
-    Auth.auth().signIn(withEmail: kOneSecondFactorUserEmail, password: kOneSecondFactorUserPassword) { (result, error) in
+    let signInExpectation = expectation(description: "Sign in with phone multi factor finished.")
+    Auth.auth().signIn(withEmail: kOneSecondFactorUserEmail, password: kOneSecondFactorUserPassword) { result, error in
       // SignIn
       guard let error = error, error.code == AuthErrorCode.secondFactorRequired.rawValue else {
         XCTFail("User sign in returns wrong error. Error: \(error!.localizedDescription)")
@@ -83,20 +84,22 @@ class PhoneMultiFactorTests: FIRAuthApiTestsBase {
       PhoneAuthProvider.provider().verifyPhoneNumber(
         with: hint,
         uiDelegate: nil,
-        multiFactorSession: resolver.session) { (verificationId, error) in
-          XCTAssertNil(error, "Failed to verify phone number. Error: \(error!.localizedDescription)")
-          let credential = PhoneAuthProvider.provider().credential(
-            withVerificationID: verificationId!,
-            verificationCode: kPhoneSecondFactorVerificationCode)
-          let assertion = PhoneMultiFactorGenerator.assertion(with: credential);
-          resolver.resolveSignIn(with: assertion) { (authResult, error) in
-            XCTAssertNil(error, "Failed to sign in with phone multi factor. Error: \(error!.localizedDescription)")
-            signInExpectation.fulfill()
-          }
+        multiFactorSession: resolver.session
+      ) { verificationId, error in
+        XCTAssertNil(error, "Failed to verify phone number. Error: \(error!.localizedDescription)")
+        let credential = PhoneAuthProvider.provider().credential(
+          withVerificationID: verificationId!,
+          verificationCode: kPhoneSecondFactorVerificationCode
+        )
+        let assertion = PhoneMultiFactorGenerator.assertion(with: credential)
+        resolver.resolveSignIn(with: assertion) { authResult, error in
+          XCTAssertNil(error, "Failed to sign in with phone multi factor. Error: \(error!.localizedDescription)")
+          signInExpectation.fulfill()
+        }
       }
     }
 
-    self.waitForExpectations(timeout: 300) { error in
+    waitForExpectations(timeout: 300) { error in
       XCTAssertNil(error, "Failed to wait for enroll and unenroll phone multi factor finished. Error: \(error!.localizedDescription)")
     }
   }

Example/Auth/App/iOS/FIRAppDelegate.h

@@ -18,6 +18,6 @@
 
 @interface FIRAppDelegate : UIResponder <UIApplicationDelegate>
 
-@property (strong, nonatomic) UIWindow *window;
+@property(strong, nonatomic) UIWindow *window;
 
 @end

Example/Auth/App/iOS/FIRAppDelegate.m

@@ -16,37 +16,40 @@
 
 @implementation FIRAppDelegate
 
-- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
-{
-    // Override point for customization after application launch.
-    return YES;
+- (BOOL)application:(UIApplication *)application
+    didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
+  // Override point for customization after application launch.
+  return YES;
 }
 
-- (void)applicationWillResignActive:(UIApplication *)application
-{
-    // Sent when the application is about to move from active to inactive state. This can occur for certain types of temporary interruptions (such as an incoming phone call or SMS message) or when the user quits the application and it begins the transition to the background state.
-    // Use this method to pause ongoing tasks, disable timers, and throttle down OpenGL ES frame rates. Games should use this method to pause the game.
+- (void)applicationWillResignActive:(UIApplication *)application {
+  // Sent when the application is about to move from active to inactive state. This can occur for
+  // certain types of temporary interruptions (such as an incoming phone call or SMS message) or
+  // when the user quits the application and it begins the transition to the background state. Use
+  // this method to pause ongoing tasks, disable timers, and throttle down OpenGL ES frame rates.
+  // Games should use this method to pause the game.
 }
 
-- (void)applicationDidEnterBackground:(UIApplication *)application
-{
-    // Use this method to release shared resources, save user data, invalidate timers, and store enough application state information to restore your application to its current state in case it is terminated later.
-    // If your application supports background execution, this method is called instead of applicationWillTerminate: when the user quits.
+- (void)applicationDidEnterBackground:(UIApplication *)application {
+  // Use this method to release shared resources, save user data, invalidate timers, and store
+  // enough application state information to restore your application to its current state in case
+  // it is terminated later. If your application supports background execution, this method is
+  // called instead of applicationWillTerminate: when the user quits.
 }
 
-- (void)applicationWillEnterForeground:(UIApplication *)application
-{
-    // Called as part of the transition from the background to the inactive state; here you can undo many of the changes made on entering the background.
+- (void)applicationWillEnterForeground:(UIApplication *)application {
+  // Called as part of the transition from the background to the inactive state; here you can undo
+  // many of the changes made on entering the background.
 }
 
-- (void)applicationDidBecomeActive:(UIApplication *)application
-{
-    // Restart any tasks that were paused (or not yet started) while the application was inactive. If the application was previously in the background, optionally refresh the user interface.
+- (void)applicationDidBecomeActive:(UIApplication *)application {
+  // Restart any tasks that were paused (or not yet started) while the application was inactive. If
+  // the application was previously in the background, optionally refresh the user interface.
 }
 
-- (void)applicationWillTerminate:(UIApplication *)application
-{
-    // Called when the application is about to terminate. Save data if appropriate. See also applicationDidEnterBackground:.
+- (void)applicationWillTerminate:(UIApplication *)application {
+  // Called when the application is about to terminate. Save data if appropriate. See also
+  // applicationDidEnterBackground:.
 }
 
 @end

Example/Auth/App/iOS/FIRViewController.m

@@ -20,16 +20,14 @@ @interface FIRViewController ()
 
 @implementation FIRViewController
 
-- (void)viewDidLoad
-{
-    [super viewDidLoad];
-	// Do any additional setup after loading the view, typically from a nib.
+- (void)viewDidLoad {
+  [super viewDidLoad];
+  // Do any additional setup after loading the view, typically from a nib.
 }
 
-- (void)didReceiveMemoryWarning
-{
-    [super didReceiveMemoryWarning];
-    // Dispose of any resources that can be recreated.
+- (void)didReceiveMemoryWarning {
+  [super didReceiveMemoryWarning];
+  // Dispose of any resources that can be recreated.
 }
 
 @end

Example/Auth/App/iOS/main.m

@@ -15,9 +15,8 @@
 @import UIKit;
 #import "FIRAppDelegate.h"
 
-int main(int argc, char * argv[])
-{
-    @autoreleasepool {
-        return UIApplicationMain(argc, argv, nil, NSStringFromClass([FIRAppDelegate class]));
-    }
+int main(int argc, char* argv[]) {
+  @autoreleasepool {
+    return UIApplicationMain(argc, argv, nil, NSStringFromClass([FIRAppDelegate class]));
+  }
 }

Example/Auth/App/macOS/FIRAppDelegate.h

@@ -18,6 +18,4 @@
 
 @interface FIRAppDelegate : NSObject <NSApplicationDelegate>
 
-
 @end
-

Example/Auth/App/macOS/FIRAppDelegate.m

@@ -23,13 +23,11 @@ @interface FIRAppDelegate ()
 @implementation FIRAppDelegate
 
 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
-    // Insert code here to initialize your application
+  // Insert code here to initialize your application
 }
 
-
 - (void)applicationWillTerminate:(NSNotification *)aNotification {
-    // Insert code here to tear down your application
+  // Insert code here to tear down your application
 }
 
-
 @end

Example/Auth/App/macOS/FIRViewController.h

@@ -18,6 +18,4 @@
 
 @interface FIRViewController : NSViewController
 
-
 @end
-