Refactor API to enforce non-null dictionary and improve naming

Author: tusharkhandelwal8

FirebaseRemoteConfig/Sources/FIRRemoteConfig.m

@@ -246,18 +246,9 @@ - (void)callListeners:(NSString *)key config:(NSDictionary *)config {
   }
 }
 
-- (void)setCustomSignals:(nullable NSDictionary<NSString *, NSObject *> *)customSignals
-          WithCompletion:(void (^_Nullable)(NSError *_Nullable error))completionHandler {
+- (void)setCustomSignals:(nonnull NSDictionary<NSString *, NSObject *> *)customSignals
+          withCompletion:(void (^_Nullable)(NSError *_Nullable error))completionHandler {
   void (^setCustomSignalsBlock)(void) = ^{
-    if (!customSignals) {
-      if (completionHandler) {
-        dispatch_async(dispatch_get_main_queue(), ^{
-          completionHandler(nil);
-        });
-      }
-      return;
-    }
-
     // Validate value type, and key and value length
     for (NSString *key in customSignals) {
       NSObject *value = customSignals[key];

FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h

@@ -370,8 +370,8 @@ typedef void (^FIRRemoteConfigUpdateCompletion)(FIRRemoteConfigUpdate *_Nullable
     (FIRRemoteConfigUpdateCompletion _Nonnull)listener
     NS_SWIFT_NAME(addOnConfigUpdateListener(remoteConfigUpdateCompletion:));
 
-- (void)setCustomSignals:(nullable NSDictionary<NSString *, NSObject *> *)customSignals
-          WithCompletion:(void (^_Nullable)(NSError *_Nullable error))completionHandler
+- (void)setCustomSignals:(nonnull NSDictionary<NSString *, NSObject *> *)customSignals
+          withCompletion:(void (^_Nullable)(NSError *_Nullable error))completionHandler
     NS_REFINED_FOR_SWIFT;
 
 @end

FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m

@@ -1834,7 +1834,7 @@ - (void)testFetchAndActivateRolloutsNotifyInterop {
   [self waitForExpectations:@[ notificationExpectation ] timeout:_expectationTimeout];
 }
 
-- (void)testSetCustomSingals {
+- (void)testSetCustomSignals {
   NSMutableArray<XCTestExpectation *> *expectations =
       [[NSMutableArray alloc] initWithCapacity:RCNTestRCNumTotalInstances];
 
@@ -1849,7 +1849,7 @@ - (void)testSetCustomSingals {
     };
 
     [_configInstances[i] setCustomSignals:testSignals
-                           WithCompletion:^(NSError *_Nullable error) {
+                           withCompletion:^(NSError *_Nullable error) {
                              XCTAssertNil(error);
                              NSMutableDictionary<NSString *, NSString *> *retrievedSignals =
                                  self->_configInstances[i].settings.customSignals;
@@ -1889,11 +1889,11 @@ - (void)testSetCustomSignalsMultipleTimes {
     };
 
     [_configInstances[i] setCustomSignals:testSignals1
-                           WithCompletion:^(NSError *_Nullable error) {
+                           withCompletion:^(NSError *_Nullable error) {
                              XCTAssertNil(error);
                              [_configInstances[i]
                                  setCustomSignals:testSignals2
-                                   WithCompletion:^(NSError *_Nullable error) {
+                                   withCompletion:^(NSError *_Nullable error) {
                                      XCTAssertNil(error);
                                      NSMutableDictionary<NSString *, NSString *> *retrievedSignals =
                                          self->_configInstances[i].settings.customSignals;
@@ -1927,19 +1927,19 @@ - (void)testSetCustomSignals_invalidInput_throwsException {
 
     [_configInstances[i]
         setCustomSignals:invalidSignals1
-          WithCompletion:^(NSError *_Nullable error) {
+          withCompletion:^(NSError *_Nullable error) {
             XCTAssertNotNil(error);
             XCTAssertEqual(error.code, FIRRemoteConfigCustomSignalsErrorInvalidValueType);
           }];
     [_configInstances[i]
         setCustomSignals:invalidSignals2
-          WithCompletion:^(NSError *_Nullable error) {
+          withCompletion:^(NSError *_Nullable error) {
             XCTAssertNotNil(error);
             XCTAssertEqual(error.code, FIRRemoteConfigCustomSignalsErrorLimitExceeded);
           }];
     [_configInstances[i]
         setCustomSignals:invalidSignals3
-          WithCompletion:^(NSError *_Nullable error) {
+          withCompletion:^(NSError *_Nullable error) {
             XCTAssertNotNil(error);
             XCTAssertEqual(error.code, FIRRemoteConfigCustomSignalsErrorLimitExceeded);
             [expectations[i] fulfill];