Skip to content

Commit 9f35987

Browse files
committed
doc comment
1 parent 5ca5414 commit 9f35987

File tree

1 file changed

+16
-25
lines changed

1 file changed

+16
-25
lines changed

.github/workflows/functions.yml

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -50,32 +50,23 @@ jobs:
5050
with:
5151
target: FirebaseFunctionsUnit
5252

53-
# TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
53+
# TODO: The legacy quickstart uses material which doesn't build on Xcode 15.
5454
# quickstart:
55-
# # Don't run on private repo unless it is a PR.
56-
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
57-
# env:
58-
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
59-
# LEGACY: true
60-
# # TODO: Move to macos-14 and Xcode 15. The legacy quickstart uses material which doesn't build on Xcode 15.
61-
# runs-on: macos-12
62-
63-
# steps:
64-
# - uses: actions/checkout@v4
65-
# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
66-
# - name: Setup quickstart
67-
# run: scripts/setup_quickstart.sh functions
68-
# - name: install secret googleservice-info.plist
69-
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-functions.plist.gpg \
70-
# quickstart-ios/functions/GoogleService-Info.plist "$plist_secret"
71-
# - name: Setup custom URL scheme
72-
# run: sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
73-
# - name: Test objc quickstart
74-
# run: ([ -z $plist_secret ] ||
75-
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true)
76-
# - name: Test swift quickstart
77-
# run: ([ -z $plist_secret ] ||
78-
# scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Functions true swift)
55+
# uses: ./.github/workflows/common_quickstart.yml
56+
# strategy:
57+
# matrix:
58+
# quickstart_type: [objc, swift]
59+
# with:
60+
# product: Functions
61+
# is_legacy: true
62+
# setup_command: |
63+
# scripts/setup_quickstart.sh functions
64+
# sed -i '' 's/REVERSED_CLIENT_ID/com.googleusercontent.apps.1025801074639-6p6ebi8amuklcjrto20gvpe295smm8u6/' quickstart-ios/functions/LegacyFunctionsQuickstart/FunctionsExample/Info.plist
65+
# plist_src_path: scripts/gha-encrypted/qs-functions.plist.gpg
66+
# plist_dst_path: quickstart-ios/functions/GoogleService-Info.plist
67+
# quickstart_type: ${{ matrix.quickstart_type }}
68+
# secrets:
69+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
7970

8071
# quickstart-ftl-cron-only:
8172
# # Don't run on private repo

0 commit comments

Comments
 (0)