(Crashlytics) Fix VeraCode scanner issue for: "LOW: Unchecked Error Condition" (#4669)

Author: jasonhu-g

Crashlytics/Crashlytics/Helpers/FIRCLSAllocate.c

@@ -175,7 +175,12 @@ void* FIRCLSAllocatorSafeAllocateFromRegion(FIRCLSAllocationRegion* region, size
     // this shouldn't happen unless we make a mistake with our size pre-computations
     if ((uintptr_t)originalCursor - (uintptr_t)region->start + size > region->size) {
       FIRCLSSDKLog("Unable to allocate sufficient memory, falling back to malloc\n");
-      return malloc(size);
+      void* ptr = malloc(size);
+      if (!ptr) {
+        FIRCLSSDKLog("Unable to malloc in FIRCLSAllocatorSafeAllocateFromRegion\n");
+        return NULL;
+      }
+      return ptr;
     }
 
     newCursor = (void*)((uintptr_t)originalCursor + size);
@@ -192,12 +197,22 @@ void* FIRCLSAllocatorSafeAllocate(FIRCLSAllocatorRef allocator,
   if (!allocator) {
     // fall back to malloc in this case
     FIRCLSSDKLog("Allocator invalid, falling back to malloc\n");
-    return malloc(size);
+    void* ptr = malloc(size);
+    if (!ptr) {
+      FIRCLSSDKLog("Unable to malloc in FIRCLSAllocatorSafeAllocate\n");
+      return NULL;
+    }
+    return ptr;
   }
 
   if (allocator->protectionEnabled) {
     FIRCLSSDKLog("Allocator already protected, falling back to malloc\n");
-    return malloc(size);
+    void* ptr = malloc(size);
+    if (!ptr) {
+      FIRCLSSDKLog("Unable to malloc in FIRCLSAllocatorSafeAllocate\n");
+      return NULL;
+    }
+    return ptr;
   }
 
   switch (type) {

Crashlytics/Crashlytics/Helpers/FIRCLSFile.m

@@ -73,6 +73,11 @@ static bool FIRCLSFileInit(FIRCLSFile* file, int fd, bool appendMode, bool buffe
   file->bufferWrites = bufferWrites;
   if (bufferWrites) {
     file->writeBuffer = malloc(FIRCLSWriteBufferLength * sizeof(char));
+    if (!file->writeBuffer) {
+      FIRCLSErrorLog(@"Unable to malloc in FIRCLSFileInit");
+      return false;
+    }
+
     file->writeBufferLength = 0;
   }
 
@@ -645,6 +650,7 @@ void FIRCLSFileWriteArrayEntryHexEncodedString(FIRCLSFile* file, const char* val
   char* encodedBuffer = malloc(length * 2 + 1);
 
   if (!encodedBuffer) {
+    FIRCLSErrorLog(@"Unable to malloc in FIRCLSFileHexEncodeString");
     return nil;
   }
 
@@ -667,6 +673,10 @@ void FIRCLSFileWriteArrayEntryHexEncodedString(FIRCLSFile* file, const char* val
 NSString* FIRCLSFileHexDecodeString(const char* string) {
   size_t length = strlen(string);
   char* decodedBuffer = malloc(length);  // too long, but safe
+  if (!decodedBuffer) {
+    FIRCLSErrorLog(@"Unable to malloc in FIRCLSFileHexDecodeString");
+    return nil;
+  }
 
   memset(decodedBuffer, 0, length);
 

Crashlytics/Crashlytics/Helpers/FIRCLSUtility.m

@@ -168,6 +168,11 @@ bool FIRCLSUnlinkIfExists(const char* path) {
   size = (length * 2) + 1;
   buffer = malloc(sizeof(char) * size);
 
+  if (!buffer) {
+    FIRCLSErrorLog(@"Unable to malloc in FIRCLSNSDataToNSString");
+    return nil;
+  }
+
   FIRCLSSafeHexToString([data bytes], length, buffer);
 
   string = [NSString stringWithUTF8String:buffer];

Crashlytics/Shared/FIRCLSByteUtility.m

@@ -60,6 +60,10 @@ void FIRCLSSafeHexToString(const uint8_t *value, size_t length, char *outputBuff
   size = (length * 2) + 1;
   buffer = malloc(sizeof(char) * size);
 
+  if (!buffer) {
+    return nil;
+  }
+
   FIRCLSSafeHexToString(data.bytes, length, buffer);
 
   string = [NSString stringWithUTF8String:buffer];

Crashlytics/Shared/FIRCLSMachO/FIRCLSMachOBinary.m

@@ -146,6 +146,10 @@ static void FIRCLSSafeHexToString(const uint8_t* value, size_t length, char* out
   size = (length * 2) + 1;
   buffer = malloc(sizeof(char) * size);
 
+  if (!buffer) {
+    return nil;
+  }
+
   FIRCLSSafeHexToString([data bytes], length, buffer);
 
   string = [NSString stringWithUTF8String:buffer];