Skip to content

Commit a15469e

Browse files
authored
Enable COUNT integration tests, now that backend support has rolled out (#10299)
1 parent c7eeffe commit a15469e

File tree

1 file changed

+0
-37
lines changed

1 file changed

+0
-37
lines changed

Firestore/Example/Tests/Integration/API/FIRCountTests.mm

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ - (void)testAggregateQueryEquals {
5858
}
5959

6060
- (void)testCanRunCountQuery {
61-
// TODO(b/246758022): Remove this (and below) once COUNT is release for the backend.
62-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
63-
return;
64-
}
65-
6661
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
6762
@"a" : @{@"k" : @"a"},
6863
@"b" : @{@"k" : @"b"},
@@ -74,10 +69,6 @@ - (void)testCanRunCountQuery {
7469
}
7570

7671
- (void)testCanRunCountWithFilters {
77-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
78-
return;
79-
}
80-
8172
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
8273
@"a" : @{@"k" : @"a"},
8374
@"b" : @{@"k" : @"b"},
@@ -90,10 +81,6 @@ - (void)testCanRunCountWithFilters {
9081
}
9182

9283
- (void)testCanRunCountWithOrderBys {
93-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
94-
return;
95-
}
96-
9784
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
9885
@"a" : @{@"k" : @"a"},
9986
@"b" : @{@"k" : @"b"},
@@ -107,10 +94,6 @@ - (void)testCanRunCountWithOrderBys {
10794
}
10895

10996
- (void)testSnapshotEquals {
110-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
111-
return;
112-
}
113-
11497
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
11598
@"a" : @{@"k" : @"a"},
11699
@"b" : @{@"k" : @"b"},
@@ -149,10 +132,6 @@ - (void)testSnapshotEquals {
149132
}
150133

151134
- (void)testTerminateDoesNotCrashWithFlyingCountQuery {
152-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
153-
return;
154-
}
155-
156135
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
157136
@"a" : @{@"k" : @"a"},
158137
@"b" : @{@"k" : @"b"},
@@ -169,10 +148,6 @@ - (void)testTerminateDoesNotCrashWithFlyingCountQuery {
169148
}
170149

171150
- (void)testCanRunCollectionGroupCountQuery {
172-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
173-
return;
174-
}
175-
176151
NSString* collectionGroup =
177152
[NSString stringWithFormat:@"%@%@", @"b",
178153
[self.db collectionWithPath:@"foo"].documentWithAutoID.documentID];
@@ -202,10 +177,6 @@ - (void)testCanRunCollectionGroupCountQuery {
202177
}
203178

204179
- (void)testCanRunCountWithFiltersAndLimits {
205-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
206-
return;
207-
}
208-
209180
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
210181
@"a" : @{@"k" : @"a"},
211182
@"b" : @{@"k" : @"a"},
@@ -230,10 +201,6 @@ - (void)testCanRunCountWithFiltersAndLimits {
230201
}
231202

232203
- (void)testCanRunCountOnNonExistentCollection {
233-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
234-
return;
235-
}
236-
237204
FIRCollectionReference* testCollection = [self collectionRef];
238205

239206
FIRAggregateQuerySnapshot* snapshot = [self readSnapshotForAggregate:[testCollection count]];
@@ -245,10 +212,6 @@ - (void)testCanRunCountOnNonExistentCollection {
245212
}
246213

247214
- (void)testFailWithoutNetwork {
248-
if (![FSTIntegrationTestCase isRunningAgainstEmulator]) {
249-
return;
250-
}
251-
252215
FIRCollectionReference* testCollection = [self collectionRefWithDocuments:@{
253216
@"a" : @{@"k" : @"a"},
254217
@"b" : @{@"k" : @"b"},

0 commit comments

Comments
 (0)