Skip to content

Commit a1da3f2

Browse files
committed
fixes
1 parent 402f572 commit a1da3f2

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

.github/workflows/common_quickstart.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ on:
2323
# secrets:
2424
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
2525
#
26-
secrets:
27-
plist_secret:
28-
required: false
26+
# secrets:
27+
# plist_secret:
28+
# required: false
2929

3030
inputs:
3131
# The product to test be tested (e.g. `FirebaseABTesting`).
@@ -75,7 +75,7 @@ jobs:
7575
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
7676
- name: Run setup command.
7777
env:
78-
LEGACY: inputs.is_legacy
78+
LEGACY: ${{ inputs.is_legacy }}
7979
run: ${{ inputs.setup_command }}
8080
- name: Install Secret GoogleService-Info.plist
8181
run: |
@@ -86,11 +86,20 @@ jobs:
8686
- name: Build ${{ inputs.product }} Quickstart
8787
uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
8888
env:
89-
LEGACY: inputs.is_legacy
89+
LEGACY: ${{ inputs.is_legacy }}
9090
with:
9191
timeout_minutes: 15
9292
max_attempts: 3
9393
retry_wait_seconds: 120
9494
command: |
9595
([ -z $plist_secret ] || scripts/test_quickstart.sh ${{ inputs.product }} true)
96+
# TODO: Add upload on fialure.
97+
# - name: Upload raw logs if failed.
98+
# if: ${{ failure() }}
99+
# uses: actions/upload-artifact@v4
100+
# with:
101+
# name:
102+
# path:
103+
104+
96105

0 commit comments

Comments
 (0)