Support array / dictionary values in Remote Config defaults (#8307)

Author: jakekrog

FirebaseRemoteConfig/Sources/RCNConfigContent.m

@@ -201,6 +201,20 @@ - (void)copyFromDictionary:(NSDictionary *)fromDict
         [dateFormatter setDateFormat:@"yyyy-MM-dd HH:mm:ss"];
         NSString *strValue = [dateFormatter stringFromDate:(NSDate *)value];
         valueData = [(NSString *)strValue dataUsingEncoding:NSUTF8StringEncoding];
+      } else if ([value isKindOfClass:[NSArray class]]) {
+        NSError *error;
+        valueData = [NSJSONSerialization dataWithJSONObject:value options:0 error:&error];
+        if (error) {
+          FIRLogError(kFIRLoggerRemoteConfig, @"I-RCN000076", @"Invalid array value for key '%@'",
+                      key);
+        }
+      } else if ([value isKindOfClass:[NSDictionary class]]) {
+        NSError *error;
+        valueData = [NSJSONSerialization dataWithJSONObject:value options:0 error:&error];
+        if (error) {
+          FIRLogError(kFIRLoggerRemoteConfig, @"I-RCN000077",
+                      @"Invalid dictionary value for key '%@'", key);
+        }
       } else {
         continue;
       }

FirebaseRemoteConfig/Tests/Unit/Defaults-testInfo.plist

@@ -16,5 +16,20 @@
 	<string>To setup default config.</string>
 	<key>format</key>
 	<string>key to value.</string>
+	<key>arrayValue</key>
+	<array>
+		<string>foo</string>
+		<string>bar</string>
+		<string>baz</string>
+	</array>
+	<key>dictValue</key>
+	<dict>
+		<key>foo</key>
+		<string>foo</string>
+		<key>bar</key>
+		<string>bar</string>
+		<key>baz</key>
+		<string>baz</string>
+	</dict>
 </dict>
 </plist>

FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m

@@ -1289,6 +1289,10 @@ - (void)testSetDefaultsFromPlist {
     XCTAssertEqualObjects(_configInstances[i][@"FileInfo"].stringValue,
                           @"To setup default config.");
     XCTAssertEqualObjects(_configInstances[i][@"format"].stringValue, @"key to value.");
+    XCTAssertEqualObjects(_configInstances[i][@"arrayValue"].JSONValue,
+                          ((id) @[ @"foo", @"bar", @"baz" ]));
+    XCTAssertEqualObjects(_configInstances[i][@"dictValue"].JSONValue,
+                          ((id) @{@"foo" : @"foo", @"bar" : @"bar", @"baz" : @"baz"}));
 
     // If given a wrong file name, the default will not be set and kept as previous results.
     [_configInstances[i] setDefaultsFromPlistFileName:@""];