Address Xcode 14.3 build warnings and a few typos (#11063)

Author: paulb777

Crashlytics/Crashlytics/Components/FIRCLSCrashedMarkerFile.c

@@ -18,7 +18,7 @@
 
 const char *FIRCLSCrashedMarkerFileName = "previously-crashed";
 
-void FIRCLSCreateCrashedMarkerFile() {
+void FIRCLSCreateCrashedMarkerFile(void) {
   FIRCLSFile file;
 
   if (!FIRCLSFileInitWithPath(&file, _firclsContext.readonly->previouslyCrashedFileFullPath, false)) {

Crashlytics/Crashlytics/Components/FIRCLSHost.m

@@ -106,7 +106,7 @@ vm_size_t FIRCLSHostGetPageSize(void) {
 
 // This comes from the Apple documentation here:
 // https://developer.apple.com/documentation/apple_silicon/about_the_rosetta_translation_environment
-bool FIRCLSHostIsRosettaTranslated() {
+bool FIRCLSHostIsRosettaTranslated(void) {
 #if TARGET_OS_MAC
   int result = 0;
   size_t size = sizeof(result);

FirebaseAuth/CHANGELOG.md

@@ -1,5 +1,5 @@
-#Unrealeased
-- [feature] Added Firebase App Check support to Firebase Auth.
+# 10.8.0
+- [added] Added Firebase App Check support to Firebase Auth.
 
 # 10.7.0
 - [added] Added an API for developers to pass the fullName from the Sign in with Apple credential to Firebase. (#10068)

FirebaseAuth/Sources/Auth/FIRAuthGlobalWorkQueue.m

@@ -18,7 +18,7 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-dispatch_queue_t FIRAuthGlobalWorkQueue() {
+dispatch_queue_t FIRAuthGlobalWorkQueue(void) {
   static dispatch_once_t once;
   static dispatch_queue_t queue;
   dispatch_once(&once, ^{

FirebaseAuth/Tests/Unit/FIRAuthBackendRPCImplementationTests.m

@@ -465,7 +465,7 @@ - (void)testRequest_IncludesHeartbeatPayload_WhenHeartbeatsNeedSending {
 /** @fn testRequest_IncludesAppCheckHeader
     @brief This test checks the behavior of @c postWithRequest:response:callback:
         to verify that a appCheck token is attached as a header to an
-        outgoing request .
+        outgoing request.
  */
 - (void)testRequest_IncludesAppCheckHeader {
   // Given

FirebaseCore/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Firebase 10.8.0
+- Fix new build warnings introduced by Xcode 14.3. (#11059)
+
 # Firebase 10.4.0
 - Deprecate `androidClientID` and `trackingID` from FirebaseOptions. (#10520)
 

FirebaseDatabaseSwift/Sources/Codable/DataSnapshot+ReadDecodable.swift

@@ -16,6 +16,7 @@
 
 import Foundation
 import FirebaseDatabase
+import FirebaseSharedSwift
 
 public extension DataSnapshot {
   /// Retrieves the value of a snapshot and converts it to an instance of

FirebaseDatabaseSwift/Sources/Codable/DatabaseReference+WriteEncodable.swift

@@ -16,6 +16,7 @@
 
 import Foundation
 import FirebaseDatabase
+import FirebaseSharedSwift
 
 public extension DatabaseReference {
   /// Encodes an instance of `Encodable` and overwrites the encoded data

FirebaseMessaging/Sources/FIRMessagingUtilities.m

@@ -39,7 +39,7 @@
 
 #pragma mark - URL Helpers
 
-NSString *FIRMessagingTokenRegisterServer() {
+NSString *FIRMessagingTokenRegisterServer(void) {
   return @"https://fcmtoken.googleapis.com/register";
 }
 
@@ -91,7 +91,7 @@ int64_t FIRMessagingCurrentTimestampInMilliseconds(void) {
 #endif
 }
 
-NSString *FIRMessagingFirebaseAppID() {
+NSString *FIRMessagingFirebaseAppID(void) {
   return [FIROptions defaultOptions].googleAppID;
 }
 
@@ -273,7 +273,7 @@ NSSearchPathDirectory FIRMessagingSupportedDirectory(void) {
   return locales;
 }
 
-NSString *FIRMessagingCurrentLocale() {
+NSString *FIRMessagingCurrentLocale(void) {
   NSArray *locales = FIRMessagingFirebaseLocales();
   NSArray *preferredLocalizations =
       [NSBundle preferredLocalizationsFromArray:locales
@@ -283,7 +283,7 @@ NSSearchPathDirectory FIRMessagingSupportedDirectory(void) {
   return legalDocsLanguage ? legalDocsLanguage : @"en";
 }
 
-BOOL FIRMessagingHasLocaleChanged() {
+BOOL FIRMessagingHasLocaleChanged(void) {
   NSString *lastLocale = [[GULUserDefaults standardUserDefaults]
       stringForKey:kFIRMessagingInstanceIDUserDefaultsKeyLocale];
   NSString *currentLocale = FIRMessagingCurrentLocale();

Firestore/core/include/firebase/firestore/timestamp.h

@@ -104,16 +104,13 @@ class Timestamp {
    * Converts `time_t` to a `Timestamp`.
    *
    * @param seconds_since_unix_epoch
-   *     @parblock
    *     The number of seconds of UTC time since Unix epoch
    *     1970-01-01T00:00:00Z. Can be negative to represent dates before the
    *     epoch. Must be from 0001-01-01T00:00:00Z to 9999-12-31T23:59:59Z
    *     inclusive; otherwise, assertion failure will be triggered.
-   *
    *     Note that while the epoch of `time_t` is unspecified, it's usually Unix
    *     epoch. If this assumption is broken, this function will produce
    *     incorrect results.
-   *     @endparblock
    *
    * @return a new timestamp with the given number of seconds and zero
    *     nanoseconds.
@@ -125,17 +122,14 @@ class Timestamp {
    * Converts `std::chrono::time_point` to a `Timestamp`.
    *
    * @param time_point
-   *     @parblock
    *     The time point with system clock's epoch, which is
    *     presumed to be Unix epoch 1970-01-01T00:00:00Z. Can be negative to
    *     represent dates before the epoch. Must be from 0001-01-01T00:00:00Z to
    *     9999-12-31T23:59:59Z inclusive; otherwise, assertion failure will be
    *     triggered.
-   *
    *     Note that while the epoch of `std::chrono::system_clock` is
    *     unspecified, it's usually Unix epoch. If this assumption is broken,
    *     this constructor will produce incorrect results.
-   *     @endparblock
    */
   static Timestamp FromTimePoint(
       std::chrono::time_point<std::chrono::system_clock> time_point);