[Performance] Address Xcode 14.3 Analyzer issues (#11241)

Author: ncooke3

FirebasePerformance/Sources/FPRNanoPbUtils.m

@@ -76,7 +76,8 @@ static firebase_perf_v1_NetworkRequestMetric_HttpMethod FPRHTTPMethodForString(
  * format.
  *  @return Current network connection type.
  */
-static firebase_perf_v1_NetworkConnectionInfo_NetworkType FPRNetworkConnectionInfoNetworkType() {
+static firebase_perf_v1_NetworkConnectionInfo_NetworkType FPRNetworkConnectionInfoNetworkType(
+    void) {
   firebase_perf_v1_NetworkConnectionInfo_NetworkType networkType =
       firebase_perf_v1_NetworkConnectionInfo_NetworkType_NONE;
 
@@ -106,7 +107,7 @@ static firebase_perf_v1_NetworkConnectionInfo_NetworkType FPRNetworkConnectionIn
  * firebase_perf_v1_NetworkConnectionInfo_MobileSubtype format.
  *  @return Current cellular network connection type.
  */
-static firebase_perf_v1_NetworkConnectionInfo_MobileSubtype FPRCellularNetworkType() {
+static firebase_perf_v1_NetworkConnectionInfo_MobileSubtype FPRCellularNetworkType(void) {
   static NSDictionary<NSString *, NSNumber *> *cellularNetworkToMobileSubtype;
   static dispatch_once_t onceToken = 0;
   dispatch_once(&onceToken, ^{
@@ -206,7 +207,7 @@ firebase_perf_v1_PerfMetric FPRGetPerfMetricMessage(NSString *appID) {
   return perfMetricMessage;
 }
 
-firebase_perf_v1_ApplicationInfo FPRGetApplicationInfoMessage() {
+firebase_perf_v1_ApplicationInfo FPRGetApplicationInfoMessage(void) {
   firebase_perf_v1_ApplicationInfo appInfoMessage = firebase_perf_v1_ApplicationInfo_init_default;
   firebase_perf_v1_IosApplicationInfo iosAppInfo = firebase_perf_v1_IosApplicationInfo_init_default;
   NSBundle *mainBundle = [NSBundle mainBundle];
@@ -433,7 +434,7 @@ firebase_perf_v1_ApplicationProcessState FPRApplicationProcessState(FPRTraceStat
 }
 
 #ifdef TARGET_HAS_MOBILE_CONNECTIVITY
-CTTelephonyNetworkInfo *FPRNetworkInfo() {
+CTTelephonyNetworkInfo *FPRNetworkInfo(void) {
   static CTTelephonyNetworkInfo *networkInfo;
   static dispatch_once_t onceToken;
   dispatch_once(&onceToken, ^{

FirebasePerformance/Sources/Gauges/Memory/FPRMemoryGaugeCollector.m

@@ -34,7 +34,7 @@ @interface FPRMemoryGaugeCollector ()
 
 @end
 
-FPRMemoryGaugeData *fprCollectMemoryMetric() {
+FPRMemoryGaugeData *fprCollectMemoryMetric(void) {
   NSDate *collectionTime = [NSDate date];
 
   struct mstats ms = mstats();

FirebasePerformance/Sources/Instrumentation/Network/Delegates/FPRNSURLConnectionDelegateInstrument.m

@@ -24,7 +24,7 @@
 #pragma mark - NSURLConnectionDelegate methods
 
 /** Returns the dispatch queue for all instrumentation to occur on. */
-static dispatch_queue_t GetInstrumentationQueue() {
+static dispatch_queue_t GetInstrumentationQueue(void) {
   static dispatch_queue_t queue;
   static dispatch_once_t token;
   dispatch_once(&token, ^{

FirebasePerformance/Sources/Instrumentation/Network/Delegates/FPRNSURLSessionDelegateInstrument.m

@@ -23,7 +23,7 @@
 #import "FirebasePerformance/Sources/Instrumentation/Network/FPRNetworkInstrumentHelpers.h"
 
 /** Returns the dispatch queue for all instrumentation to occur on. */
-static dispatch_queue_t GetInstrumentationQueue() {
+static dispatch_queue_t GetInstrumentationQueue(void) {
   static dispatch_queue_t queue;
   static dispatch_once_t token;
   dispatch_once(&token, ^{

FirebasePerformance/Sources/Instrumentation/Network/FPRNSURLConnectionInstrument.m

@@ -35,7 +35,7 @@ typedef void (^FPRNSURLConnectionCompletionHandler)(NSURLResponse *_Nullable res
                                                     NSError *_Nullable connectionError);
 
 /** Returns the dispatch queue for all instrumentation to occur on. */
-static dispatch_queue_t GetInstrumentationQueue() {
+static dispatch_queue_t GetInstrumentationQueue(void) {
   static dispatch_queue_t queue = nil;
   static dispatch_once_t token = 0;
   dispatch_once(&token, ^{

FirebasePerformance/Sources/Instrumentation/Network/FPRNSURLSessionInstrument.m

@@ -51,7 +51,7 @@ - (void)registerProxyObject:(id)proxy;
 @end
 
 /** Returns the dispatch queue for all instrumentation to occur on. */
-static dispatch_queue_t GetInstrumentationQueue() {
+static dispatch_queue_t GetInstrumentationQueue(void) {
   static dispatch_queue_t queue = nil;
   static dispatch_once_t token = 0;
   dispatch_once(&token, ^{

FirebasePerformance/Sources/Instrumentation/UIKit/FPRUIViewControllerInstrument.m

@@ -27,7 +27,7 @@
 #import <GoogleUtilities/GULOriginalIMPConvenienceMacros.h>
 
 /** Returns the dispatch queue for all instrumentation to occur on. */
-static dispatch_queue_t GetInstrumentationQueue() {
+static dispatch_queue_t GetInstrumentationQueue(void) {
   static dispatch_queue_t queue = nil;
   static dispatch_once_t token = 0;
   dispatch_once(&token, ^{
@@ -40,7 +40,7 @@ static dispatch_queue_t GetInstrumentationQueue() {
 // Returns the singleton UIApplication of the application this is currently running in or nil if
 // it's in an app extension.
 NS_EXTENSION_UNAVAILABLE("Firebase Performance is not supported for extensions.")
-static UIApplication *FPRSharedApplication() {
+static UIApplication *FPRSharedApplication(void) {
   if ([GULAppEnvironmentUtil isAppExtension]) {
     return nil;
   }