Skip to content

Commit ac77d2e

Browse files
authored
Review Firestore local unit test files (#13387)
1 parent 9bc5fd5 commit ac77d2e

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Firestore/core/test/unit/local/leveldb_index_manager_test.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,13 @@ TEST_F(LevelDbIndexManagerTest, OrderByKeyFilter) {
180180
AddDoc("coll/val3", Map("count", 3));
181181

182182
{
183-
SCOPED_TRACE("Verifing OrderByKey ASC");
183+
SCOPED_TRACE("Verifying OrderByKey ASC");
184184
auto query = Query("coll").AddingOrderBy(OrderBy("count"));
185185
VerifyResults(query, {"coll/val1", "coll/val2", "coll/val3"});
186186
}
187187

188188
{
189-
SCOPED_TRACE("Verifing OrderByKey DESC");
189+
SCOPED_TRACE("Verifying OrderByKey DESC");
190190
auto query = Query("coll").AddingOrderBy(OrderBy("count", "desc"));
191191
VerifyResults(query, {"coll/val3", "coll/val2", "coll/val1"});
192192
}
@@ -204,11 +204,11 @@ TEST_F(LevelDbIndexManagerTest, AscendingOrderWithLessThanFilter) {
204204
.AddingFilter(Filter("c", "<", 5))
205205
.AddingOrderBy(OrderBy("c", "asc"));
206206
{
207-
SCOPED_TRACE("Verifing original");
207+
SCOPED_TRACE("Verifying original");
208208
VerifyResults(original_query, {"coll/val2", "coll/val3", "coll/val4"});
209209
}
210210
{
211-
SCOPED_TRACE("Verifing non-restricted bound");
211+
SCOPED_TRACE("Verifying non-restricted bound");
212212
auto query_with_non_restricted_bound =
213213
original_query
214214
.StartingAt(Bound::FromValue(Array(1), /* inclusive= */ false))
@@ -217,7 +217,7 @@ TEST_F(LevelDbIndexManagerTest, AscendingOrderWithLessThanFilter) {
217217
{"coll/val2", "coll/val3", "coll/val4"});
218218
}
219219
{
220-
SCOPED_TRACE("Verifing restricted bound");
220+
SCOPED_TRACE("Verifying restricted bound");
221221
auto query_with_restricted_bound =
222222
original_query
223223
.StartingAt(Bound::FromValue(Array(2), /* inclusive= */ false))
@@ -776,7 +776,7 @@ TEST_F(LevelDbIndexManagerTest, EqualsWithNotEqualsOnSameField) {
776776
for (const auto& filter : filter_result_pair.first) {
777777
query = query.AddingFilter(filter);
778778
}
779-
SCOPED_TRACE(absl::StrCat("Verifing case#", counter++));
779+
SCOPED_TRACE(absl::StrCat("Verifying case#", counter++));
780780
VerifyResults(query, filter_result_pair.second);
781781
}
782782
});

Firestore/core/test/unit/local/lru_garbage_collector_test.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ struct LruParams;
5050

5151
/**
5252
* A set of helper methods needed by LruGarbageCollectorTest that customize it
53-
* to the specific implemetnation it is testing.
53+
* to the specific implementation it is testing.
5454
*/
5555
class LruGarbageCollectorTestHelper {
5656
public:

Firestore/core/test/unit/local/mutation_queue_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ TEST_P(MutationQueueTest, NextMutationBatchAfterBatchId) {
199199
}
200200

201201
for (size_t i = 0; i < removed.size(); i++) {
202-
// Searching for deleted batch IDs should return the next batch higest
202+
// Searching for deleted batch IDs should return the next batch highest
203203
// batch ID that's still in the queue.
204204
const MutationBatch& current = removed[i];
205205
const MutationBatch& next = batches.front();

0 commit comments

Comments
 (0)