Skip to content

Commit ae8a5ed

Browse files
committed
self review
1 parent 849c138 commit ae8a5ed

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

FirebaseRemoteConfig/SwiftNew/ConfigDBManager.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,7 @@ open class ConfigDBManager: NSObject {
190190
Task { // Use Task to call the actor method asynchronously
191191
let table = await self.databaseActor.loadMetadataTable(withBundleIdentifier: bundleIdentifier,
192192
namespace: namespace)
193-
Task {
194-
handler(table) // Call the completion handler
195-
}
193+
handler(table) // Call the completion handler
196194
}
197195
}
198196

FirebaseRemoteConfig/Tests/Unit/RCNConfigContentTest.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ @interface RCNConfigContent (Testing)
3333
- (BOOL)checkAndWaitForInitialDatabaseLoad;
3434
@end
3535

36+
// TODO: These depend on RCNConfigDBManager subclassing. Reimplement in Swift.
3637
// extern const NSTimeInterval kDatabaseLoadTimeoutSecs;
3738
//@interface RCNConfigDBManagerMock : RCNConfigDBManager
3839
//@property(nonatomic, assign) BOOL isLoadMainCompleted;

0 commit comments

Comments
 (0)