add missing return when delete token handler is nil (#5247) (#5248)

ryanwilson · charlotteliang · web-flow · commit b2921405e2ff · 2020-04-01T16:29:30.000-04:00
Co-authored-by: Chen Liang &lt;chliang@google.com&gt;
diff --git a/Firebase/InstanceID/CHANGELOG.md b/Firebase/InstanceID/CHANGELOG.md
@@ -1,5 +1,6 @@
 # 2020-03 -- 4.3.3
 - [fixed] Fixed provisioning profile location for catalyst. (#5048)
+- [fixed] Fixed crash when passing a nil handler to deleteToken request. (#5247)
 - [changed] Remove obsolete logic to improve performance and reduce keychain operations. (#5211, #5237)
 
 # 2020-02 -- 4.3.2
diff --git a/Firebase/InstanceID/FIRInstanceID.m b/Firebase/InstanceID/FIRInstanceID.m
@@ -367,6 +367,7 @@ - (void)deleteTokenWithAuthorizedEntity:(NSString *)authorizedEntity
   if (!handler) {
     FIRInstanceIDLoggerError(kFIRInstanceIDMessageCodeInstanceID001,
                              kFIRInstanceIDInvalidNilHandlerError);
+    return;
   }
 
   // comparing enums to ints directly throws a warning

Original file line number	Diff line number	Diff line change
`@@ -367,6 +367,7 @@ - (void)deleteTokenWithAuthorizedEntity:(NSString *)authorizedEntity`
`367`	`367`	`if (!handler) {`
`368`	`368`	`FIRInstanceIDLoggerError(kFIRInstanceIDMessageCodeInstanceID001,`
`369`	`369`	`kFIRInstanceIDInvalidNilHandlerError);`
	`370`	`+ return;`
`370`	`371`	`}`
`371`	`372`
`372`	`373`	`// comparing enums to ints directly throws a warning`