Stop calling deprecated sendLogsWithServiceName (#3333)

paulb777 · web-flow · commit b35ca19ede8c · 2019-07-11T07:04:53.000-07:00
diff --git a/Firebase/DynamicLinks/FIRDynamicLinks.m b/Firebase/DynamicLinks/FIRDynamicLinks.m
@@ -194,7 +194,6 @@ - (void)configureDynamicLinks:(FIRApp *)app {
                                                        reason:errorDescription];
   }
   if (error) {
-    [app sendLogsWithServiceName:kFIRServiceDynamicLinks version:kFIRDLVersion error:error];
     NSString *message = nil;
     if (options.usingOptionsFromDefaultPlist) {
       // Configured using plist file
diff --git a/Firebase/InstanceID/FIRInstanceID.m b/Firebase/InstanceID/FIRInstanceID.m
@@ -697,13 +697,7 @@ + (NSError *)configureErrorWithReason:(nonnull NSString *)reason {
                          userInfo:userInfo];
 }
 
-// If the firebaseApp is available we should send logs for the error through it before
-// raising an exception.
 + (void)exitWithReason:(nonnull NSString *)reason forFirebaseApp:(FIRApp *)firebaseApp {
-  [firebaseApp sendLogsWithServiceName:kFIRIIDServiceInstanceID
-                               version:FIRInstanceIDCurrentLibraryVersion()
-                                 error:[self configureErrorWithReason:reason]];
-
   [NSException raise:kFIRIIDErrorDomain
               format:@"Could not configure Firebase InstanceID. %@", reason];
 }

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,6 @@ - (void)configureDynamicLinks:(FIRApp *)app {`
`194`	`194`	`reason:errorDescription];`
`195`	`195`	`}`
`196`	`196`	`if (error) {`
`197`		`- [app sendLogsWithServiceName:kFIRServiceDynamicLinks version:kFIRDLVersion error:error];`
`198`	`197`	`NSString *message = nil;`
`199`	`198`	`if (options.usingOptionsFromDefaultPlist) {`
`200`	`199`	`// Configured using plist file`
Original file line number	Diff line number	Diff line change
`@@ -697,13 +697,7 @@ + (NSError )configureErrorWithReason:(nonnull NSString )reason {`
`697`	`697`	`userInfo:userInfo];`
`698`	`698`	`}`
`699`	`699`
`700`		`-// If the firebaseApp is available we should send logs for the error through it before`
`701`		`-// raising an exception.`
`702`	`700`	`+ (void)exitWithReason:(nonnull NSString )reason forFirebaseApp:(FIRApp )firebaseApp {`
`703`		`- [firebaseApp sendLogsWithServiceName:kFIRIIDServiceInstanceID`
`704`		`- version:FIRInstanceIDCurrentLibraryVersion()`
`705`		`- error:[self configureErrorWithReason:reason]];`
`706`		`-`
`707`	`701`	`[NSException raise:kFIRIIDErrorDomain`
`708`	`702`	`format:@"Could not configure Firebase InstanceID. %@", reason];`
`709`	`703`	`}`