Skip to content

Commit b56b93d

Browse files
committed
more migration
1 parent c4f8183 commit b56b93d

File tree

6 files changed

+281
-342
lines changed

6 files changed

+281
-342
lines changed

.github/workflows/crashlytics.yml

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,31 +44,21 @@ jobs:
4444
quickstart:
4545
# Don't run on private repo unless it is a PR.
4646
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
47-
48-
env:
49-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
50-
runs-on: macos-15
51-
steps:
52-
- uses: actions/checkout@v4
53-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
54-
- name: Xcode
55-
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
56-
- name: Setup quickstart
57-
run: scripts/setup_quickstart.sh crashlytics
58-
env:
59-
LEGACY: true
60-
- name: Install Secret GoogleService-Info.plist
61-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \
62-
quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret"
63-
- name: Test swift quickstart
64-
run: |
47+
uses: ./.github/workflows/common_quickstart.yml
48+
with:
49+
product: Crashlytics
50+
is_legacy: true
51+
quickstart_type: swift
52+
setup_command: |
53+
scripts/setup_quickstart.sh crashlytics
6554
mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics
6655
# Set the deployed pod location of run and upload-symbols with the development pod version.
6756
cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/
6857
cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/
69-
([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Crashlytics true swift)
70-
env:
71-
LEGACY: true
58+
plist_src_path: scripts/gha-encrypted/qs-crashlytics.plist.gpg
59+
plist_dst_path: quickstart-ios/crashlytics/GoogleService-Info.plist
60+
secrets:
61+
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
7262

7363
quickstart-ftl-cron-only:
7464
# Don't run on private repo.

.github/workflows/inappmessaging.yml

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -85,27 +85,16 @@ jobs:
8585
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseInAppMessaging.podspec --platforms=${{ matrix.platform }} ${{ matrix.flags }}
8686

8787
quickstart:
88-
# Don't run on private repo unless it is a PR.
89-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
90-
91-
env:
88+
uses: ./.github/workflows/common_quickstart.yml
89+
strategy:
90+
matrix:
91+
quickstart_type: [objc, swift]
92+
with:
93+
product: InAppMessaging
94+
is_legacy: false
95+
quickstart_type: ${{ matrix.quickstart_type }}
96+
setup_command: scripts/setup_quickstart.sh inappmessaging
97+
plist_src_path: scripts/gha-encrypted/qs-inappmessaging.plist.gpg
98+
plist_dst_path: quickstart-ios/inappmessaging/GoogleService-Info.plist
99+
secrets:
92100
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
93-
runs-on: macos-15
94-
95-
steps:
96-
- uses: actions/checkout@v4
97-
- uses: actions/checkout@v4
98-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
99-
- name: Xcode
100-
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
101-
- name: Setup quickstart
102-
run: scripts/setup_quickstart.sh inappmessaging
103-
- name: install secret googleservice-info.plist
104-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \
105-
quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret"
106-
- name: Test objc quickstart
107-
run: ([ -z $plist_secret ] ||
108-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh InAppMessaging true)
109-
- name: Test swift quickstart
110-
run: ([ -z $plist_secret ] ||
111-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh InAppMessaging true swift)

.github/workflows/messaging.yml

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -82,30 +82,20 @@ jobs:
8282
quickstart:
8383
# Don't run on private repo unless it is a PR.
8484
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
85-
env:
86-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
85+
uses: ./.github/workflows/common_quickstart.yml
8786
strategy:
8887
matrix:
89-
include:
90-
- os: macos-15
91-
xcode: Xcode_16.4
92-
runs-on: ${{ matrix.os }}
93-
steps:
94-
- uses: actions/checkout@v4
95-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
96-
- name: Setup quickstart
97-
run: scripts/setup_quickstart.sh messaging
98-
- name: Install Secret GoogleService-Info.plist
99-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \
100-
quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret"
101-
- name: Xcode
102-
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
103-
- name: Test objc quickstart
104-
run: ([ -z $plist_secret ] ||
105-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Messaging false)
106-
- name: Test swift quickstart
107-
run: ([ -z $plist_secret ] ||
108-
scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Messaging false swift)
88+
quickstart_type: [objc, swift]
89+
with:
90+
product: Messaging
91+
is_legacy: false
92+
quickstart_type: ${{ matrix.quickstart_type }}
93+
setup_command: scripts/setup_quickstart.sh messaging
94+
plist_src_path: scripts/gha-encrypted/qs-messaging.plist.gpg
95+
plist_dst_path: quickstart-ios/messaging/GoogleService-Info.plist
96+
run_tests: false
97+
secrets:
98+
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
10999

110100
quickstart-ftl-cron-only:
111101
# Don't run on private repo.

.github/workflows/performance.yml

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -78,25 +78,16 @@ jobs:
7878

7979
quickstart:
8080
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
81-
82-
env:
81+
uses: ./.github/workflows/common_quickstart.yml
82+
with:
83+
product: Performance
84+
is_legacy: false
85+
quickstart_type: swift
86+
setup_command: scripts/setup_quickstart.sh performance
87+
plist_src_path: scripts/gha-encrypted/qs-performance.plist.gpg
88+
plist_dst_path: quickstart-ios/performance/GoogleService-Info.plist
89+
secrets:
8390
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
84-
runs-on: macos-15
85-
steps:
86-
- uses: actions/checkout@v4
87-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
88-
- name: Xcode
89-
run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer
90-
- name: Setup quickstart
91-
run: scripts/setup_quickstart.sh performance
92-
- name: Install Secret GoogleService-Info.plist
93-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-performance.plist.gpg \
94-
quickstart-ios/performance/GoogleService-Info.plist "$plist_secret"
95-
- name: Test swift quickstart
96-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Performance true swift)
97-
# TODO: The legacy ObjC quickstarts don't run with Xcode 15, re-able if we get these working.
98-
# - name: Test objc quickstart
99-
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Performance true)
10091

10192
quickstart-ftl-cron-only:
10293
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'

0 commit comments

Comments
 (0)