Skip to content

Commit b745465

Browse files
committed
Implement feedback from review
1 parent 39133d6 commit b745465

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

FirebaseRemoteConfig/CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Unreleased
2-
- [added] Introduced a new `updates` property to `RemoteConfig` that
3-
provides an `AsyncThrowingStream` for consuming real-time config updates.
2+
- [added] Introduced a new `configUpdates` property to `RemoteConfig` that
3+
provides an `AsyncSequence` for consuming real-time config updates.
44
This offers a modern, Swift Concurrency-native alternative to the existing
55
closure-based listener.
66

FirebaseRemoteConfig/Swift/RemoteConfig+Async.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import Foundation
1616

1717
@available(iOS 13.0.0, macOS 10.15.0, macCatalyst 13.0.0, tvOS 13.0.0, watchOS 7.0.0, *)
1818
public extension RemoteConfig {
19-
/// Returns an `AsyncThrowingStream` that provides real-time updates to the configuration.
19+
/// Returns an `AsyncSequence` that provides real-time updates to the configuration.
2020
///
2121
/// You can listen for updates by iterating over the stream using a `for try await` loop.
2222
/// The stream will yield a `RemoteConfigUpdate` whenever a change is pushed from the
@@ -26,7 +26,7 @@ public extension RemoteConfig {
2626
/// The underlying listener is automatically added when you begin iterating and is removed when
2727
/// the iteration is cancelled or finishes.
2828
///
29-
/// - Throws: `RemoteConfigUpdateError` if the listener encounters a server-side error or another
29+
/// - Throws: An `Error` if the listener encounters a server-side error or another
3030
/// issue, causing the stream to terminate.
3131
///
3232
/// ### Example Usage
@@ -47,7 +47,7 @@ public extension RemoteConfig {
4747
/// }
4848
/// }
4949
/// ```
50-
@available(iOS 18.0, *)
50+
@available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
5151
var configUpdates: some AsyncSequence<RemoteConfigUpdate, Error> {
5252
AsyncThrowingStream { continuation in
5353
let listener = addOnConfigUpdateListener { update, error in

FirebaseRemoteConfig/Tests/Swift/SwiftAPI/AsyncSequenceTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class MockRealtime: RCNConfigRealtime, @unchecked Sendable {
6464

6565
// MARK: - AsyncSequenceTests
6666

67-
@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
67+
@available(macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0, *)
6868
class AsyncSequenceTests: XCTestCase {
6969
var app: FirebaseApp!
7070
var config: RemoteConfig!

0 commit comments

Comments
 (0)