Fix perf assert macro (#8521)

Author: paulb777

FirebasePerformance/Sources/Common/FPRDiagnostics.h

@@ -43,11 +43,13 @@ FOUNDATION_EXTERN void __FPRAssert(id object, BOOL condition, const char *func);
 // This assert adds additional functionality to the normal NSAssert, including printing out
 // information when NSAsserts are stripped. A __builtin_expect is utilized to keep running speed
 // as fast as possible.
-#define FPRAssert(condition, ...)               \
-  do {                                          \
-    __FPRAssert(self, !!(condition), __func__); \
-    NSAssert(condition, __VA_ARGS__);           \
-  } while (0);
+#define FPRAssert(condition, ...)                 \
+  {                                               \
+    do {                                          \
+      __FPRAssert(self, !!(condition), __func__); \
+      NSAssert(condition, __VA_ARGS__);           \
+    } while (0);                                  \
+  }
 
 /** This class handles the control of diagnostics in the SDK. */
 @interface FPRDiagnostics : NSObject

FirebasePerformance/Tests/Unit/Common/FPRDiagnosticsTest.m

@@ -80,7 +80,7 @@ - (void)testFPRAssertSpeed {
 
 /** Tests that FPRAssert actually asserts (when NS_BLOCK_ASSERTIONS=0|undefined). */
 - (void)testFPRAssert {
-  XCTAssertThrows({FPRAssert(NO, @"This is a failed assert!")});
+  XCTAssertThrows(FPRAssert(NO, @"This is a failed assert!"));
 }
 
 /** Tests emit diagnostics methods. */