Merge branch 'nc/auth-swift' into nc/auth-swift6-1

Author: ncooke3

.github/actions/notices_generation/action.yml

@@ -40,7 +40,7 @@ runs:
       fi
     shell: bash
   - name: Upload artifacts
-    uses: actions/upload-artifact@v3
+    uses: actions/upload-artifact@v4
     with:
       name: notices
       path: ${{ inputs.notices-path }}

.github/workflows/health-metrics-presubmit.yml

@@ -75,7 +75,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseABTesting --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -95,7 +95,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseAuth --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -120,7 +120,7 @@ jobs:
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDatabase --platform=${{ matrix.target }}
       # TODO: Make sure that https://github.com/actions/upload-artifact/issues/478 is resolved
       # before going to actions/upload-artifact@v4.
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -143,7 +143,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDynamicLinks --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -169,7 +169,7 @@ jobs:
       run: |
         export EXPERIMENTAL_MODE=true
         ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseFirestore --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -192,7 +192,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseFunctions --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -215,7 +215,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseInAppMessaging --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -238,7 +238,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseMessaging --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -264,7 +264,7 @@ jobs:
       run: gem install xcpretty
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebasePerformance --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -287,7 +287,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseRemoteConfig --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult
@@ -310,7 +310,7 @@ jobs:
       run: scripts/setup_bundler.sh
     - name: Build and test
       run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseStorage --platform=${{ matrix.target }}
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: codecoverage
         path: /Users/runner/*.xcresult

.github/workflows/spm.yml

@@ -21,6 +21,9 @@ concurrency:
     group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
     cancel-in-progress: true
 
+env:
+  FIREBASE_CI: true
+
 jobs:
   spm-package-resolved:
     env:

Crashlytics/CHANGELOG.md

@@ -1,5 +1,9 @@
+# 11.5.0
+- [changed] Updated `upload-symbols` to version 3.19, removed all methods require CFRelease and switch to modern classes (#13420).
+
 # 11.4.0
 - [fixed] Updated `upload-symbols` to version 3.18 with support for uploading multiple DWARF contents in a dSYM bundle (#13543).
+- [fixed] Fixed upload-symbols run script argument order (#13965).
 
 # 10.28.1
 - [changed] Reverted "Add SIGTERM support (#12881)" (#13117)

Crashlytics/Crashlytics/Public/FirebaseCrashlytics/FIRCrashlytics.h

@@ -59,8 +59,8 @@ NS_SWIFT_NAME(Crashlytics)
  * Adds logging that is sent with your crash data. The logging does not appear in app
  * logs and is only visible in the Crashlytics dashboard.
  *
- * @param format Format of string
- * @param ... A comma-separated list of arguments to substitute into format
+ * @param format The format of the string, followed by a comma-separated list
+ * of arguments to substitute into the format.
  */
 - (void)logWithFormat:(NSString *)format, ... NS_FORMAT_FUNCTION(1, 2);
 

Crashlytics/Crashlytics/Public/FirebaseCrashlytics/FIRCrashlyticsReport.h

@@ -56,8 +56,8 @@ NS_SWIFT_NAME(CrashlyticsReport)
  * Adds logging that is sent with your crash data. The logging does not appear  in the
  * system.log and is only visible in the Crashlytics dashboard.
  *
- * @param format Format of string
- * @param ... A comma-separated list of arguments to substitute into format
+ * @param format The format of the string, followed by a comma-separated list
+ * of arguments to substitute into the format.
  */
 - (void)logWithFormat:(NSString *)format, ... NS_FORMAT_FUNCTION(1, 2);
 

Crashlytics/run

@@ -46,8 +46,8 @@ for i in "$@"; do
   ARGUMENTS="$ARGUMENTS \"$i\""
 done
 
-VALIDATE_ARGUMENTS="$ARGUMENTS --build-phase --validate"
-UPLOAD_ARGUMENTS="$ARGUMENTS --build-phase"
+VALIDATE_ARGUMENTS="--build-phase --validate $ARGUMENTS"
+UPLOAD_ARGUMENTS="--build-phase $ARGUMENTS "
 
 # Quote the path to handle folders with special characters
 COMMAND_PATH="\"$DIR/upload-symbols\" "

Crashlytics/upload-symbols

@@ -253,8 +253,6 @@ extension Auth: AuthInterop {
 
   /// Sets the `currentUser` on the receiver to the provided user object.
   /// - Parameter user: The user object to be set as the current user of the calling Auth instance.
-  /// - Parameter completion: Optionally; a block invoked after the user of the calling Auth
-  /// instance has been updated or an error was encountered.
   @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
   open func updateCurrentUser(_ user: User) async throws {
     return try await withCheckedThrowingContinuation { continuation in
@@ -1431,6 +1429,7 @@ extension Auth: AuthInterop {
   }
 
   /// Revoke the users token with authorization code.
+  /// - Parameter authorizationCode: The authorization code used to perform the revocation.
   /// - Parameter completion: (Optional) the block invoked when the request to revoke the token is
   /// complete, or fails. Invoked asynchronously on the main thread in the future.
   @objc open func revokeToken(withAuthorizationCode authorizationCode: String,
@@ -1451,8 +1450,7 @@ extension Auth: AuthInterop {
   }
 
   /// Revoke the users token with authorization code.
-  /// - Parameter completion: (Optional) the block invoked when the request to revoke the token is
-  /// complete, or fails. Invoked asynchronously on the main thread in the future.
+  /// - Parameter authorizationCode: The authorization code used to perform the revocation.
   @available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
   open func revokeToken(withAuthorizationCode authorizationCode: String) async throws {
     return try await withCheckedThrowingContinuation { continuation in

FirebaseAuth/Sources/Swift/Auth/Auth.swift

@@ -22,6 +22,9 @@ import Foundation
     /// Used to obtain an auth credential via a mobile web flow.
     /// This method is available on iOS only.
     /// - Parameter uiDelegate: An optional UI delegate used to present the mobile web flow.
+    /// - Parameter completionHandler: Optionally; a block which is invoked
+    /// asynchronously on the main thread when the mobile web flow is
+    /// completed.
     @available(iOS 13, tvOS 13, macOS 10.15, watchOS 8, *)
     @objc(getCredentialWithUIDelegate:completion:)
     func credential(with uiDelegate: AuthUIDelegate?) async throws -> AuthCredential