Skip to content

Commit c9da4eb

Browse files
authored
Add defaults for data collection state fields. (#10517)
1 parent 0b7fc7e commit c9da4eb

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

FirebaseSessions/Sources/SessionStartEvent.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ class SessionStartEvent: NSObject, GDTCOREventDataObject {
4949
// proto.application_info.apple_app_info.network_connection_info
5050
proto.application_info.apple_app_info.os_name = convertOSName(osName: appInfo.osName)
5151
proto.application_info.apple_app_info.mcc_mnc = makeProtoString(appInfo.mccMNC)
52+
53+
proto.session_data.data_collection_status
54+
.crashlytics = firebase_appquality_sessions_DataCollectionState_COLLECTION_UNKNOWN
55+
proto.session_data.data_collection_status
56+
.performance = firebase_appquality_sessions_DataCollectionState_COLLECTION_UNKNOWN
5257
}
5358

5459
func setInstallationID(identifiers: IdentifierProvider) {

FirebaseSessions/Tests/Unit/SessionStartEventTests.swift

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,4 +166,21 @@ class SessionStartEventTests: XCTestCase {
166166
XCTAssertEqual(event.proto.application_info.log_environment, expected)
167167
}
168168
}
169+
170+
func test_dataCollectionState_defaultIsUnknown() {
171+
identifiers.mockAllValidIDs()
172+
173+
let event = SessionStartEvent(identifiers: identifiers, appInfo: appInfo, time: time)
174+
175+
testProtoAndDecodedProto(sessionEvent: event) { proto in
176+
XCTAssertEqual(
177+
proto.session_data.data_collection_status.performance,
178+
firebase_appquality_sessions_DataCollectionState_COLLECTION_UNKNOWN
179+
)
180+
XCTAssertEqual(
181+
proto.session_data.data_collection_status.crashlytics,
182+
firebase_appquality_sessions_DataCollectionState_COLLECTION_UNKNOWN
183+
)
184+
}
185+
}
169186
}

0 commit comments

Comments
 (0)