Skip to content

Commit ca0ae6b

Browse files
authored
fix: Fixes to artifact uploads and scheme name-related issues (#15437)
1 parent f7a8628 commit ca0ae6b

File tree

1 file changed

+11
-17
lines changed

1 file changed

+11
-17
lines changed

.github/workflows/zip.yml

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ jobs:
248248
- uses: actions/upload-artifact@v4
249249
if: failure()
250250
with:
251-
name: quickstart_artifacts_abtesting
251+
name: quickstart_artifacts_abtesting_${{ matrix.artifact }}
252252
path: |
253253
quickstart-ios/
254254
!quickstart-ios/**/GoogleService-Info.plist
@@ -298,7 +298,7 @@ jobs:
298298
- uses: actions/upload-artifact@v4
299299
if: failure()
300300
with:
301-
name: quickstart_artifacts_auth
301+
name: quickstart_artifacts_auth_${{ matrix.artifact }}
302302
path: |
303303
quickstart-ios/
304304
!quickstart-ios/**/GoogleService-Info.plist
@@ -349,7 +349,7 @@ jobs:
349349
- uses: actions/upload-artifact@v4
350350
if: failure()
351351
with:
352-
name: quickstart_artifacts_config
352+
name: quickstart_artifacts_config_${{ matrix.artifact }}
353353
path: quickstart-ios/
354354

355355
quickstart_framework_crashlytics:
@@ -417,7 +417,7 @@ jobs:
417417
- uses: actions/upload-artifact@v4
418418
if: failure()
419419
with:
420-
name: quickstart_artifacts_crashlytics
420+
name: quickstart_artifacts_crashlytics_${{ matrix.artifact }}
421421
path: |
422422
quickstart-ios/
423423
!quickstart-ios/**/GoogleService-Info.plist
@@ -453,7 +453,7 @@ jobs:
453453
find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} +
454454
- uses: actions/checkout@v4
455455
- name: Setup quickstart
456-
run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \
456+
run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \
457457
"${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \
458458
"${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \
459459
"${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \
@@ -464,11 +464,11 @@ jobs:
464464
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \
465465
quickstart-ios/database/GoogleService-Info.plist "$plist_secret"
466466
- name: Test Quickstart
467-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
467+
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
468468
- uses: actions/upload-artifact@v4
469469
if: failure()
470470
with:
471-
name: quickstart_artifacts_database
471+
name: quickstart_artifacts_database_${{ matrix.artifact }}
472472
path: |
473473
quickstart-ios/
474474
!quickstart-ios/**/GoogleService-Info.plist
@@ -565,17 +565,15 @@ jobs:
565565
run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \
566566
"${HOME}"/ios_frameworks/Firebase/FirebaseInAppMessaging/* \
567567
"${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/*
568-
- name: Setup swift quickstart
569-
run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh
570568
- name: Install Secret GoogleService-Info.plist
571569
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \
572570
quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret"
573571
- name: Test Swift Quickstart
574-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
572+
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
575573
- uses: actions/upload-artifact@v4
576574
if: failure()
577575
with:
578-
name: quickstart_artifacts_inappmessaging
576+
name: quickstart_artifacts_inappmessaging_${{ matrix.artifact }}
579577
path: |
580578
quickstart-ios/
581579
!quickstart-ios/**/GoogleService-Info.plist
@@ -615,8 +613,6 @@ jobs:
615613
run: SAMPLE="$SDK" TARGET="${SDK}Example" scripts/setup_quickstart_framework.sh \
616614
"${HOME}"/ios_frameworks/Firebase/FirebaseMessaging/* \
617615
"${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/*
618-
- name: Setup swift quickstart
619-
run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh
620616
- name: Install Secret GoogleService-Info.plist
621617
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-messaging.plist.gpg \
622618
quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret"
@@ -625,7 +621,7 @@ jobs:
625621
- uses: actions/upload-artifact@v4
626622
if: failure()
627623
with:
628-
name: quickstart_artifacts_messaging
624+
name: quickstart_artifacts_messaging_${{ matrix.artifact }}
629625
path: |
630626
quickstart-ios/
631627
!quickstart-ios/**/GoogleService-Info.plist
@@ -666,8 +662,6 @@ jobs:
666662
"${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \
667663
"${HOME}"/ios_frameworks/Firebase/FirebaseAuth/* \
668664
"${HOME}"/ios_frameworks/Firebase/FirebaseAnalytics/*
669-
- name: Setup swift quickstart
670-
run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" scripts/setup_quickstart_framework.sh
671665
- name: Install Secret GoogleService-Info.plist
672666
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
673667
quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
@@ -676,7 +670,7 @@ jobs:
676670
- uses: actions/upload-artifact@v4
677671
if: failure()
678672
with:
679-
name: quickstart_artifacts_storage
673+
name: quickstart_artifacts_storage_${{ matrix.artifact }}
680674
path: |
681675
quickstart-ios/
682676
!quickstart-ios/**/GoogleService-Info.plist

0 commit comments

Comments
 (0)