remove backpointer to parent

Author: cherylEnkidu

Firestore/Swift/Source/ExpressionImplementation.swift

@@ -225,7 +225,7 @@ extension Expression {
   func bitRightShift(_ numberExpression: Expression) -> FunctionExpression {
     return FunctionExpression("bit_right_shift", [self, numberExpression])
   }
-  
+
   /// Calculates the Manhattan (L1) distance between this vector expression and another vector
   /// expression.
   /// Assumes both `self` and `other` evaluate to Vectors.
@@ -271,7 +271,7 @@ extension Expression {
   func manhattanDistance(_ vector: [Double]) -> FunctionExpression {
     return FunctionExpression("manhattan_distance", [self, Helper.sendableToExpr(vector)])
   }
-  
+
   /// Creates an expression that replaces the first occurrence of a literal substring within this
   /// string expression with another literal substring.
   /// Assumes `self` evaluates to a string.
@@ -284,7 +284,7 @@ extension Expression {
   /// - Parameter find: The literal string substring to search for.
   /// - Parameter replace: The literal string substring to replace the first occurrence with.
   /// - Returns: A new `FunctionExpr` representing the string with the first occurrence replaced.
-  func replaceFirst(_ find: String, with replace: String) -> FunctionExpression{
+  func replaceFirst(_ find: String, with replace: String) -> FunctionExpression {
     return FunctionExpression(
       "replace_first",
       [self, Helper.sendableToExpr(find), Helper.sendableToExpr(replace)]
@@ -304,7 +304,7 @@ extension Expression {
   /// - Parameter replace: An `Expr` (evaluating to a string) for the substring to replace the first
   /// occurrence with.
   /// - Returns: A new `FunctionExpr` representing the string with the first occurrence replaced.
-  func replaceFirst(_ find: Expression, with replace: Expression) -> FunctionExpression{
+  func replaceFirst(_ find: Expression, with replace: Expression) -> FunctionExpression {
     return FunctionExpression("replace_first", [self, find, replace])
   }
 
@@ -320,7 +320,7 @@ extension Expression {
   /// - Parameter find: The literal string substring to search for.
   /// - Parameter replace: The literal string substring to replace all occurrences with.
   /// - Returns: A new `FunctionExpr` representing the string with all occurrences replaced.
-  func stringReplace(_ find: String, with replace: String) -> FunctionExpression{
+  func stringReplace(_ find: String, with replace: String) -> FunctionExpression {
     return FunctionExpression(
       "string_replace",
       [self, Helper.sendableToExpr(find), Helper.sendableToExpr(replace)]
@@ -340,10 +340,9 @@ extension Expression {
   /// - Parameter replace: An `Expression` (evaluating to a string) for the substring to replace all
   /// occurrences with.
   /// - Returns: A new `FunctionExpression` representing the string with all occurrences replaced.
-  func stringReplace(_ find: Expression, with replace: Expression) -> FunctionExpression{
+  func stringReplace(_ find: Expression, with replace: Expression) -> FunctionExpression {
     return FunctionExpression("string_replace", [self, find, replace])
   }
-  
 }
 
 public extension Expression {

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -87,11 +87,8 @@ public struct Pipeline: @unchecked Sendable {
     self.db = db
     bridge = PipelineBridge(stages: stages.map { $0.bridge }, db: db)
   }
-  
-  public struct Snapshot: Sendable {
-    /// The Pipeline on which `execute()` was called to obtain this `Pipeline.Snapshot`.
-    public let pipeline: Pipeline
 
+  public struct Snapshot: Sendable {
     /// An array of all the results in the `Pipeline.Snapshot`.
     public let results: [PipelineResult]
 
@@ -100,9 +97,8 @@ public struct Pipeline: @unchecked Sendable {
 
     let bridge: __PipelineSnapshotBridge
 
-    init(_ bridge: __PipelineSnapshotBridge, pipeline: Pipeline) {
+    init(_ bridge: __PipelineSnapshotBridge) {
       self.bridge = bridge
-      self.pipeline = pipeline
       executionTime = self.bridge.execution_time
       results = self.bridge.results.map { PipelineResult($0) }
     }
@@ -133,7 +129,7 @@ public struct Pipeline: @unchecked Sendable {
         if let error {
           continuation.resume(throwing: error)
         } else {
-          continuation.resume(returning: Pipeline.Snapshot(result!, pipeline: self))
+          continuation.resume(returning: Pipeline.Snapshot(result!))
         }
       }
     }

Firestore/Swift/Source/SwiftAPI/Pipeline/RealtimePipeline.swift

@@ -79,11 +79,8 @@ struct RealtimePipeline: @unchecked Sendable {
     self.db = db
     bridge = RealtimePipelineBridge(stages: stages.map { $0.bridge }, db: db)
   }
-  
-  struct Snapshot: Sendable {
-    /// The Pipeline on which `execute()` was called to obtain this `Pipeline.Snapshot`.
-    public let pipeline: RealtimePipeline
 
+  struct Snapshot: Sendable {
     /// An array of all the results in the `Pipeline.Snapshot`.
     let results_cache: [PipelineResult]
 
@@ -94,10 +91,8 @@ struct RealtimePipeline: @unchecked Sendable {
     private var options: PipelineListenOptions
 
     init(_ bridge: __RealtimePipelineSnapshotBridge,
-         pipeline: RealtimePipeline,
          options: PipelineListenOptions) {
       self.bridge = bridge
-      self.pipeline = pipeline
       self.options = options
       metadata = bridge.metadata
       results_cache = self.bridge.results
@@ -118,7 +113,6 @@ struct RealtimePipeline: @unchecked Sendable {
         listener(
           RealtimePipeline.Snapshot(
             snapshotBridge!,
-            pipeline: self,
             options: options
           ),
           error

Firestore/Swift/Tests/Integration/PipelineTests.swift

@@ -1988,7 +1988,7 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
 
     TestHelper.compare(snapshot: snapshot, expected: expectedResults, enforceOrder: true)
   }
-  
+
   func testReverseWorksOnArray() async throws {
     let collRef = collectionRef(withDocuments: [
       "doc1": ["tags": ["a", "b", "c"]],