Skip to content

Commit d0c9ded

Browse files
authored
Fix race condition between setting developer mode and config fetch (#5600)
1 parent b57f8b2 commit d0c9ded

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

FirebaseRemoteConfig/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# v4.4.11
2+
- [fixed] Fixed a bug where settings updates weren't applied before fetches. (#4740)
3+
- [changed] Updated public API documentation for 4.4.10 change from FirebaseInstanceID to
4+
FirebaseInstallations. (#5561)
15
# v4.4.10
26
- [changed] Internal code changes - migrate to using the FIS SDK. (#5096)
37
- [changed] Include both CFBundleString and CFBundleShortVersionString in the outgoing fetch requests.

FirebaseRemoteConfig/Sources/FIRRemoteConfig.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,10 @@ - (void)ensureInitializedWithCompletionHandler:
214214
#pragma mark - fetch
215215

216216
- (void)fetchWithCompletionHandler:(FIRRemoteConfigFetchCompletion)completionHandler {
217-
[self fetchWithExpirationDuration:_settings.minimumFetchInterval
218-
completionHandler:completionHandler];
217+
dispatch_async(_queue, ^{
218+
[self fetchWithExpirationDuration:self->_settings.minimumFetchInterval
219+
completionHandler:completionHandler];
220+
});
219221
}
220222

221223
- (void)fetchWithExpirationDuration:(NSTimeInterval)expirationDuration

0 commit comments

Comments
 (0)