Skip to content

Commit d21fb17

Browse files
committed
minor code cleanup
1 parent 514ce75 commit d21fb17

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

Firestore/core/src/core/composite_filter.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
#include "Firestore/core/src/core/composite_filter.h"
1818

1919
#include <algorithm>
20+
#include <memory>
2021
#include <utility>
2122

2223
#include "Firestore/core/src/core/field_filter.h"
2324
#include "Firestore/core/src/model/field_path.h"
2425
#include "Firestore/core/src/util/hard_assert.h"
2526
#include "Firestore/core/src/util/string_format.h"
26-
#include "absl/memory/memory.h"
2727
#include "absl/strings/str_join.h"
2828

2929
namespace firebase {
@@ -143,7 +143,7 @@ const FieldFilter* CompositeFilter::Rep::FindFirstMatchingFilter(
143143
}
144144

145145
std::shared_ptr<std::vector<FieldFilter>> CompositeFilter::Rep::CalculateFlattenedFilters() const {
146-
auto flattened_filters = absl::make_unique<std::vector<FieldFilter>>();
146+
auto flattened_filters = std::make_shared<std::vector<FieldFilter>>();
147147
for (const auto& filter : filters())
148148
std::copy(filter.GetFlattenedFilters().begin(),
149149
filter.GetFlattenedFilters().end(),

Firestore/core/src/core/field_filter.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#include "Firestore/core/src/core/field_filter.h"
1818

19+
#include <memory>
1920
#include <utility>
2021

2122
#include "Firestore/core/src/core/array_contains_any_filter.h"
@@ -32,7 +33,6 @@
3233
#include "Firestore/core/src/util/hard_assert.h"
3334
#include "Firestore/core/src/util/hashing.h"
3435
#include "absl/algorithm/container.h"
35-
#include "absl/memory/memory.h"
3636
#include "absl/strings/str_cat.h"
3737
#include "absl/types/optional.h"
3838

Firestore/core/src/core/filter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ class Filter {
115115
protected:
116116
class Rep {
117117
public:
118+
Rep() = default;
119+
118120
virtual ~Rep() = default;
119121

120122
virtual Type type() const {

Firestore/core/src/core/query.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
#include "Firestore/core/src/util/hard_assert.h"
3232
#include "Firestore/core/src/util/hashing.h"
3333
#include "absl/algorithm/container.h"
34-
#include "absl/memory/memory.h"
3534
#include "absl/strings/str_cat.h"
3635

3736
namespace firebase {

0 commit comments

Comments
 (0)