Early return for rollouts write errors (#13103)

themiswang · web-flow · commit d44fabfb312c · 2024-06-10T13:30:23.000-04:00
diff --git a/Crashlytics/Crashlytics/Controllers/FIRCLSRolloutsPersistenceManager.m b/Crashlytics/Crashlytics/Controllers/FIRCLSRolloutsPersistenceManager.m
@@ -59,13 +59,15 @@ - (void)updateRolloutsStateToPersistenceWithRollouts:(NSData *_Nonnull)rollouts
     if (![_fileManager createFileAtPath:rolloutsPath contents:nil attributes:nil]) {
       FIRCLSDebugLog(@"Could not create rollouts.clsrecord file. Error was code: %d - message: %s",
                      errno, strerror(errno));
+      return;
     }
   }
 
   NSFileHandle *rolloutsFile = [NSFileHandle fileHandleForUpdatingAtPath:rolloutsPath];
 
   if (!_rolloutsLoggingQueue) {
     FIRCLSDebugLog(@"Rollouts logging queue is dealloccated");
+    return;
   }
 
   dispatch_async(_rolloutsLoggingQueue, ^{

Original file line number	Diff line number	Diff line change
`@@ -59,13 +59,15 @@ - (void)updateRolloutsStateToPersistenceWithRollouts:(NSData *_Nonnull)rollouts`
`59`	`59`	`if (![_fileManager createFileAtPath:rolloutsPath contents:nil attributes:nil]) {`
`60`	`60`	`FIRCLSDebugLog(@"Could not create rollouts.clsrecord file. Error was code: %d - message: %s",`
`61`	`61`	`errno, strerror(errno));`
	`62`	`+ return;`
`62`	`63`	`}`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`NSFileHandle *rolloutsFile = [NSFileHandle fileHandleForUpdatingAtPath:rolloutsPath];`
`66`	`67`
`67`	`68`	`if (!_rolloutsLoggingQueue) {`
`68`	`69`	`FIRCLSDebugLog(@"Rollouts logging queue is dealloccated");`
	`70`	`+ return;`
`69`	`71`	`}`
`70`	`72`
`71`	`73`	`dispatch_async(_rolloutsLoggingQueue, ^{`