Skip to content

Commit d603c7b

Browse files
authored
Fix health-metrics (#12345)
1 parent 2d3ecf9 commit d603c7b

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

.github/workflows/health-metrics-presubmit.yml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
run: scripts/setup_bundler.sh
7373
- name: Build and test
7474
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseABTesting --platform=${{ matrix.target }}
75-
- uses: actions/upload-artifact@v4
75+
- uses: actions/upload-artifact@v3
7676
with:
7777
name: codecoverage
7878
path: /Users/runner/*.xcresult
@@ -92,7 +92,7 @@ jobs:
9292
run: scripts/setup_bundler.sh
9393
- name: Build and test
9494
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseAuth --platform=${{ matrix.target }}
95-
- uses: actions/upload-artifact@v4
95+
- uses: actions/upload-artifact@v3
9696
with:
9797
name: codecoverage
9898
path: /Users/runner/*.xcresult
@@ -115,7 +115,9 @@ jobs:
115115
run: scripts/setup_bundler.sh
116116
- name: Build and test
117117
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDatabase --platform=${{ matrix.target }}
118-
- uses: actions/upload-artifact@v4
118+
# TODO: Make sure that https://github.com/actions/upload-artifact/issues/478 is resolved
119+
# before going to actions/upload-artifact@v4.
120+
- uses: actions/upload-artifact@v3
119121
with:
120122
name: codecoverage
121123
path: /Users/runner/*.xcresult
@@ -138,7 +140,7 @@ jobs:
138140
run: scripts/setup_bundler.sh
139141
- name: Build and test
140142
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseDynamicLinks --platform=${{ matrix.target }}
141-
- uses: actions/upload-artifact@v4
143+
- uses: actions/upload-artifact@v3
142144
with:
143145
name: codecoverage
144146
path: /Users/runner/*.xcresult
@@ -164,7 +166,7 @@ jobs:
164166
run: |
165167
export EXPERIMENTAL_MODE=true
166168
./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseFirestore --platform=${{ matrix.target }}
167-
- uses: actions/upload-artifact@v4
169+
- uses: actions/upload-artifact@v3
168170
with:
169171
name: codecoverage
170172
path: /Users/runner/*.xcresult
@@ -187,7 +189,7 @@ jobs:
187189
run: scripts/setup_bundler.sh
188190
- name: Build and test
189191
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseFunctions --platform=${{ matrix.target }}
190-
- uses: actions/upload-artifact@v4
192+
- uses: actions/upload-artifact@v3
191193
with:
192194
name: codecoverage
193195
path: /Users/runner/*.xcresult
@@ -210,7 +212,7 @@ jobs:
210212
run: scripts/setup_bundler.sh
211213
- name: Build and test
212214
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseInAppMessaging --platform=${{ matrix.target }}
213-
- uses: actions/upload-artifact@v4
215+
- uses: actions/upload-artifact@v3
214216
with:
215217
name: codecoverage
216218
path: /Users/runner/*.xcresult
@@ -233,7 +235,7 @@ jobs:
233235
run: scripts/setup_bundler.sh
234236
- name: Build and test
235237
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseMessaging --platform=${{ matrix.target }}
236-
- uses: actions/upload-artifact@v4
238+
- uses: actions/upload-artifact@v3
237239
with:
238240
name: codecoverage
239241
path: /Users/runner/*.xcresult
@@ -258,7 +260,7 @@ jobs:
258260
run: gem install xcpretty
259261
- name: Build and test
260262
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebasePerformance --platform=${{ matrix.target }}
261-
- uses: actions/upload-artifact@v4
263+
- uses: actions/upload-artifact@v3
262264
with:
263265
name: codecoverage
264266
path: /Users/runner/*.xcresult
@@ -281,7 +283,7 @@ jobs:
281283
run: scripts/setup_bundler.sh
282284
- name: Build and test
283285
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseRemoteConfig --platform=${{ matrix.target }}
284-
- uses: actions/upload-artifact@v4
286+
- uses: actions/upload-artifact@v3
285287
with:
286288
name: codecoverage
287289
path: /Users/runner/*.xcresult
@@ -304,7 +306,7 @@ jobs:
304306
run: scripts/setup_bundler.sh
305307
- name: Build and test
306308
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh --sdk=FirebaseStorage --platform=${{ matrix.target }}
307-
- uses: actions/upload-artifact@v4
309+
- uses: actions/upload-artifact@v3
308310
with:
309311
name: codecoverage
310312
path: /Users/runner/*.xcresult
@@ -331,7 +333,7 @@ jobs:
331333
scripts/decrypt_gha_secret.sh scripts/gha-encrypted/metrics_service_access.json.gpg \
332334
metrics-access.json "${{ env.METRICS_SERVICE_SECRET }}"
333335
gcloud auth activate-service-account --key-file metrics-access.json
334-
- uses: actions/download-artifact@v4
336+
- uses: actions/download-artifact@v3
335337
id: download
336338
with:
337339
path: /Users/runner/test

scripts/health_metrics/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ pod-lib-lint-newsdk:
3333
run: scripts/setup_bundler.sh
3434
- name: Build and test
3535
run: ./scripts/health_metrics/pod_test_code_coverage_report.sh FirebaseNewSDK "${{ matrix.target }}"
36-
- uses: actions/upload-artifact@v2
36+
- uses: actions/upload-artifact@v3
3737
with:
3838
name: codecoverage
3939
path: /Users/runner/*.xcresult

0 commit comments

Comments
 (0)