Fixed Error Handling for Async Fetcher Calls

yakovmanshin · yakovmanshin · commit d77a97dcb714 · 2024-10-29T18:03:35.000+01:00
* `GTMSessionFetcher`’s async `beginFetch()` method returns either data or error, but not both (unlike the completion-handler variant)
* Without the data, `processedResponseData(from:error:)` has less details and can’t categorize the error correctly
* However, the same details can be retrieved from the error’s user info
diff --git a/FirebaseFunctions/Sources/Functions.swift b/FirebaseFunctions/Sources/Functions.swift
@@ -536,7 +536,7 @@ enum FunctionsConstants {
       if error.domain == kGTMSessionFetcherStatusDomain {
         localError = FunctionsError(
           httpStatusCode: error.code,
-          body: data,
+          body: data ?? error.userInfo["data"] as? Data,
           serializer: serializer
         )
       } else if error.domain == NSURLErrorDomain, error.code == NSURLErrorTimedOut {

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ enum FunctionsConstants {`
`536`	`536`	`if error.domain == kGTMSessionFetcherStatusDomain {`
`537`	`537`	`localError = FunctionsError(`
`538`	`538`	`httpStatusCode: error.code,`
`539`		`- body: data,`
	`539`	`+ body: data ?? error.userInfo["data"] as? Data,`
`540`	`540`	`serializer: serializer`
`541`	`541`	`)`
`542`	`542`	`} else if error.domain == NSURLErrorDomain, error.code == NSURLErrorTimedOut {`