Skip to content

Commit e190b63

Browse files
authored
Revert "Add new danger check (#10338)" (#10355)
This reverts commit 7668a85.
1 parent 6d24463 commit e190b63

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

Dangerfile

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,6 @@ def hasChangesIn(paths)
2424
return false
2525
end
2626

27-
# Determine if any new files were added to paths matching any of the
28-
# path patterns provided.
29-
def hasAdditionsIn(paths)
30-
path_array = Array(paths)
31-
path_array.each do |dir|
32-
if !git.added_files.grep(/#{dir}/).empty?
33-
return true
34-
end
35-
end
36-
return false
37-
end
38-
3927
# Adds the provided labels to the current PR.
4028
def addLabels(label_array)
4129
issue_number = github.pr_json["number"]
@@ -130,8 +118,6 @@ has_license_changes = didModify(["LICENSE"])
130118
@has_storage_changes = hasChangesIn("FirebaseStorage")
131119

132120
@has_releasetooling_changes = hasChangesIn("ReleaseTooling/")
133-
@has_public_additions = hasAdditionsIn("Public/")
134-
@has_umbrella_changes = hasChangesIn("Firebase*.h")
135121

136122
# Convenient flag for all API changes.
137123
@has_api_changes = @has_abtesting_api_changes ||
@@ -178,14 +164,6 @@ if has_sdk_changes
178164
end
179165
end
180166

181-
# Warn if a new public header file is added but no umbrella header changes
182-
# are detected. Prevents regression of #10301
183-
if @has_public_additions && !@has_umbrella_changes
184-
error = "New public headers were added, "\
185-
"did you remember to add them to the umbrella header?"
186-
fail(error)
187-
end
188-
189167
# Error on license edits
190168
fail("LICENSE changes are explicitly disallowed.") if has_license_changes
191169

0 commit comments

Comments
 (0)