@@ -24,18 +24,6 @@ def hasChangesIn(paths)
24
24
return false
25
25
end
26
26
27
- # Determine if any new files were added to paths matching any of the
28
- # path patterns provided.
29
- def hasAdditionsIn ( paths )
30
- path_array = Array ( paths )
31
- path_array . each do |dir |
32
- if !git . added_files . grep ( /#{ dir } / ) . empty?
33
- return true
34
- end
35
- end
36
- return false
37
- end
38
-
39
27
# Adds the provided labels to the current PR.
40
28
def addLabels ( label_array )
41
29
issue_number = github . pr_json [ "number" ]
@@ -130,8 +118,6 @@ has_license_changes = didModify(["LICENSE"])
130
118
@has_storage_changes = hasChangesIn ( "FirebaseStorage" )
131
119
132
120
@has_releasetooling_changes = hasChangesIn ( "ReleaseTooling/" )
133
- @has_public_additions = hasAdditionsIn ( "Public/" )
134
- @has_umbrella_changes = hasChangesIn ( "Firebase*.h" )
135
121
136
122
# Convenient flag for all API changes.
137
123
@has_api_changes = @has_abtesting_api_changes ||
@@ -178,14 +164,6 @@ if has_sdk_changes
178
164
end
179
165
end
180
166
181
- # Warn if a new public header file is added but no umbrella header changes
182
- # are detected. Prevents regression of #10301
183
- if @has_public_additions && !@has_umbrella_changes
184
- error = "New public headers were added, " \
185
- "did you remember to add them to the umbrella header?"
186
- fail ( error )
187
- end
188
-
189
167
# Error on license edits
190
168
fail ( "LICENSE changes are explicitly disallowed." ) if has_license_changes
191
169
0 commit comments