Skip to content

Commit e42cce2

Browse files
committed
merge in base 2
1 parent 418e3a6 commit e42cce2

File tree

4 files changed

+4
-34
lines changed

4 files changed

+4
-34
lines changed

Firestore/Source/Public/FirebaseFirestore/FIRPipelineBridge.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,6 @@ NS_SWIFT_NAME(__PipelineResultBridge)
222222

223223
- (nullable id)get:(id)field;
224224

225-
- (nullable id)get:(id)field
226-
serverTimestampBehavior:(FIRServerTimestampBehavior)serverTimestampBehavior;
227-
228225
@end
229226

230227
NS_SWIFT_SENDABLE

Firestore/Swift/Source/SwiftAPI/Pipeline/PipelineResult.swift

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -22,28 +22,16 @@ import Foundation
2222
@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
2323
public struct PipelineResult: @unchecked Sendable {
2424
let bridge: __PipelineResultBridge
25-
private let serverTimestamp: ServerTimestampBehavior
2625

2726
init(_ bridge: __PipelineResultBridge) {
2827
self.bridge = bridge
29-
serverTimestamp = .none
3028
ref = self.bridge.reference
3129
id = self.bridge.documentID
3230
data = self.bridge.data().mapValues { Helper.convertObjCToSwift($0) }
3331
createTime = self.bridge.create_time
3432
updateTime = self.bridge.update_time
3533
}
3634

37-
init(_ bridge: __PipelineResultBridge, _ behavior: ServerTimestampBehavior) {
38-
self.bridge = bridge
39-
serverTimestamp = behavior
40-
ref = self.bridge.reference
41-
id = self.bridge.documentID
42-
data = self.bridge.data(with: serverTimestamp)
43-
createTime = self.bridge.create_time
44-
updateTime = self.bridge.update_time
45-
}
46-
4735
/// The reference of the document, if the query returns the `__name__` field.
4836
public let ref: DocumentReference?
4937

@@ -63,29 +51,20 @@ public struct PipelineResult: @unchecked Sendable {
6351
/// - Parameter fieldPath: The field path (e.g., "foo" or "foo.bar").
6452
/// - Returns: The data at the specified field location or `nil` if no such field exists.
6553
public func get(_ fieldName: String) -> Sendable? {
66-
return Helper.convertObjCToSwift(bridge.get(
67-
fieldName,
68-
serverTimestampBehavior: serverTimestamp
69-
))
54+
return Helper.convertObjCToSwift(bridge.get(fieldName))
7055
}
7156

7257
/// Retrieves the field specified by `fieldPath`.
7358
/// - Parameter fieldPath: The field path (e.g., "foo" or "foo.bar").
7459
/// - Returns: The data at the specified field location or `nil` if no such field exists.
7560
public func get(_ fieldPath: FieldPath) -> Sendable? {
76-
return Helper.convertObjCToSwift(bridge.get(
77-
fieldPath,
78-
serverTimestampBehavior: serverTimestamp
79-
))
61+
return Helper.convertObjCToSwift(bridge.get(fieldPath))
8062
}
8163

8264
/// Retrieves the field specified by `fieldPath`.
8365
/// - Parameter fieldPath: The field path (e.g., "foo" or "foo.bar").
8466
/// - Returns: The data at the specified field location or `nil` if no such field exists.
8567
public func get(_ field: Field) -> Sendable? {
86-
return Helper.convertObjCToSwift(bridge.get(
87-
field.fieldName,
88-
serverTimestampBehavior: serverTimestamp
89-
))
68+
return Helper.convertObjCToSwift(bridge.get(field.fieldName))
9069
}
9170
}

Firestore/core/src/api/stages.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include "Firestore/core/src/api/api_fwd.h"
3030
#include "Firestore/core/src/api/expressions.h"
3131
#include "Firestore/core/src/api/ordering.h"
32-
#include "Firestore/core/src/core/listen_options.h"
3332
#include "Firestore/core/src/model/model_fwd.h"
3433
#include "Firestore/core/src/model/resource_path.h"
3534
#include "Firestore/core/src/nanopb/message.h"
@@ -63,13 +62,8 @@ class EvaluateContext {
6362
return *serializer_;
6463
}
6564

66-
const core::ListenOptions& listen_options() const {
67-
return listen_options_;
68-
}
69-
7065
private:
7166
remote::Serializer* serializer_;
72-
core::ListenOptions listen_options_;
7367
};
7468

7569
// Subclass of Stage that supports cache evaluation.

Firestore/core/src/core/query_listener.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,4 +196,4 @@ void QueryListener::RaiseInitialEvent(const ViewSnapshot& snapshot) {
196196

197197
} // namespace core
198198
} // namespace firestore
199-
} // namespace firebase
199+
} // namespace firebase

0 commit comments

Comments
 (0)