Fix heap-buffer overflow in FPREncodePerfSessions (#8872)

* Fix heap-buffer overflow in FPREncodePerfSessions

* Update CHANGELOG.md

* Update CHANGELOG.md

* Attempt to add sanitizers to workflow.

* Update performance.yml

* Update performance.yml

* Update performance.yml

* Remove sanitizer check.

Author: jeremyjiang-dev

FirebasePerformance/CHANGELOG.md

@@ -1,10 +1,11 @@
 # Unreleased
 * Fix a crash related to FPRSessionDetails. (#8691)
+* Fix heap-buffer overflow when encoding sessions. (#8849)
 
 # Version 8.8.0
 * Create a random number of delay for remote config fetch during app starts.
 * Fix log spamming when Firebase Performance is disabled. (#8423, #8577)
-* Fix heap-heap-buffer overflow when decoding strings. (#8628)
+* Fix heap-buffer overflow when decoding strings. (#8628)
 
 # Version 8.6.1
 * Fix the case where the event were dropped for missing a critical field in the event.

FirebasePerformance/Sources/FPRNanoPbUtils.m

@@ -184,12 +184,12 @@ static firebase_perf_v1_NetworkConnectionInfo_MobileSubtype FPRCellularNetworkTy
     perfSessions[perfSessionIndex].session_verbosity_count = 0;
     if ((session.options & FPRSessionOptionsEvents) ||
         (session.options & FPRSessionOptionsGauges)) {
+      perfSessions[perfSessionIndex].session_verbosity_count = 1;
       perfSessions[perfSessionIndex].session_verbosity =
           calloc(perfSessions[perfSessionIndex].session_verbosity_count,
                  sizeof(firebase_perf_v1_SessionVerbosity));
       perfSessions[perfSessionIndex].session_verbosity[0] =
           firebase_perf_v1_SessionVerbosity_GAUGES_AND_SYSTEM_EVENTS;
-      perfSessions[perfSessionIndex].session_verbosity_count = 1;
     }
     perfSessionIndex++;
   }];