Skip to content

Commit ecac4b2

Browse files
authored
Apply suggestions from code review
1 parent f067f5f commit ecac4b2

29 files changed

+50
-50
lines changed

Firebase.podspec

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
3535
s.subspec 'Core' do |ss|
3636
ss.ios.deployment_target = '15.0'
3737
ss.osx.deployment_target = '10.15'
38-
ss.ios.deployment_target = '15.0'
38+
ss.tvos.deployment_target = '15.0'
3939
ss.ios.dependency 'FirebaseAnalytics', '~> 11.15.0'
4040
ss.osx.dependency 'FirebaseAnalytics', '~> 11.15.0'
4141
ss.tvos.dependency 'FirebaseAnalytics', '~> 11.15.0'
@@ -57,28 +57,28 @@ Simplify your app development, grow your user base, and monetize more effectivel
5757
end
5858
ss.ios.deployment_target = '15.0'
5959
ss.osx.deployment_target = '10.15'
60-
ss.ios.deployment_target = '15.0'
60+
ss.tvos.deployment_target = '15.0'
6161
ss.watchos.deployment_target = '7.0'
6262
end
6363

6464
s.subspec 'Analytics' do |ss|
6565
ss.ios.deployment_target = '15.0'
6666
ss.osx.deployment_target = '10.15'
67-
ss.ios.deployment_target = '15.0'
67+
ss.tvos.deployment_target = '15.0'
6868
ss.dependency 'Firebase/Core'
6969
end
7070

7171
s.subspec 'AnalyticsWithAdIdSupport' do |ss|
7272
ss.ios.deployment_target = '15.0'
7373
ss.osx.deployment_target = '10.15'
74-
ss.ios.deployment_target = '15.0'
74+
ss.tvos.deployment_target = '15.0'
7575
ss.dependency 'Firebase/Core'
7676
end
7777

7878
s.subspec 'AnalyticsWithoutAdIdSupport' do |ss|
7979
ss.ios.deployment_target = '15.0'
8080
ss.osx.deployment_target = '10.15'
81-
ss.ios.deployment_target = '15.0'
81+
ss.tvos.deployment_target = '15.0'
8282
ss.dependency 'FirebaseAnalytics/WithoutAdIdSupport', '~> 11.15.0'
8383
ss.dependency 'Firebase/CoreOnly'
8484
end
@@ -89,7 +89,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
8989
# Standard platforms PLUS watchOS.
9090
ss.ios.deployment_target = '15.0'
9191
ss.osx.deployment_target = '10.15'
92-
ss.ios.deployment_target = '15.0'
92+
ss.tvos.deployment_target = '15.0'
9393
ss.watchos.deployment_target = '7.0'
9494
end
9595

@@ -104,7 +104,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
104104
ss.dependency 'FirebaseAppCheck', '~> 11.15.0'
105105
ss.ios.deployment_target = '15.0'
106106
ss.osx.deployment_target = '10.15'
107-
ss.ios.deployment_target = '15.0'
107+
ss.tvos.deployment_target = '15.0'
108108
ss.watchos.deployment_target = '7.0'
109109
end
110110

@@ -114,7 +114,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
114114
# Standard platforms PLUS watchOS.
115115
ss.ios.deployment_target = '15.0'
116116
ss.osx.deployment_target = '10.15'
117-
ss.ios.deployment_target = '15.0'
117+
ss.tvos.deployment_target = '15.0'
118118
ss.watchos.deployment_target = '7.0'
119119
end
120120

@@ -124,7 +124,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
124124
# Standard platforms PLUS watchOS.
125125
ss.ios.deployment_target = '15.0'
126126
ss.osx.deployment_target = '10.15'
127-
ss.ios.deployment_target = '15.0'
127+
ss.tvos.deployment_target = '15.0'
128128
ss.watchos.deployment_target = '7.0'
129129
end
130130

@@ -134,7 +134,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
134134
# Standard platforms PLUS watchOS 7.
135135
ss.ios.deployment_target = '15.0'
136136
ss.osx.deployment_target = '10.15'
137-
ss.ios.deployment_target = '15.0'
137+
ss.tvos.deployment_target = '15.0'
138138
ss.watchos.deployment_target = '7.0'
139139
end
140140

@@ -152,7 +152,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
152152
# Standard platforms PLUS watchOS.
153153
ss.ios.deployment_target = '15.0'
154154
ss.osx.deployment_target = '10.15'
155-
ss.ios.deployment_target = '15.0'
155+
ss.tvos.deployment_target = '15.0'
156156
ss.watchos.deployment_target = '7.0'
157157
end
158158

@@ -161,7 +161,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
161161
ss.ios.dependency 'FirebaseInAppMessaging', '~> 11.15.0-beta'
162162
ss.tvos.dependency 'FirebaseInAppMessaging', '~> 11.15.0-beta'
163163
ss.ios.deployment_target = '15.0'
164-
ss.ios.deployment_target = '15.0'
164+
ss.tvos.deployment_target = '15.0'
165165
end
166166

167167
s.subspec 'Installations' do |ss|
@@ -175,7 +175,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
175175
# Standard platforms PLUS watchOS.
176176
ss.ios.deployment_target = '15.0'
177177
ss.osx.deployment_target = '10.15'
178-
ss.ios.deployment_target = '15.0'
178+
ss.tvos.deployment_target = '15.0'
179179
ss.watchos.deployment_target = '7.0'
180180
end
181181

@@ -185,7 +185,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
185185
# Standard platforms PLUS watchOS.
186186
ss.ios.deployment_target = '15.0'
187187
ss.osx.deployment_target = '10.15'
188-
ss.ios.deployment_target = '15.0'
188+
ss.tvos.deployment_target = '15.0'
189189
ss.watchos.deployment_target = '7.0'
190190
end
191191

@@ -194,7 +194,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
194194
ss.ios.dependency 'FirebasePerformance', '~> 11.15.0'
195195
ss.tvos.dependency 'FirebasePerformance', '~> 11.15.0'
196196
ss.ios.deployment_target = '15.0'
197-
ss.ios.deployment_target = '15.0'
197+
ss.tvos.deployment_target = '15.0'
198198
end
199199

200200
s.subspec 'RemoteConfig' do |ss|
@@ -203,7 +203,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
203203
# Standard platforms PLUS watchOS.
204204
ss.ios.deployment_target = '15.0'
205205
ss.osx.deployment_target = '10.15'
206-
ss.ios.deployment_target = '15.0'
206+
ss.tvos.deployment_target = '15.0'
207207
ss.watchos.deployment_target = '7.0'
208208
end
209209

@@ -213,7 +213,7 @@ Simplify your app development, grow your user base, and monetize more effectivel
213213
# Standard platforms PLUS watchOS.
214214
ss.ios.deployment_target = '15.0'
215215
ss.osx.deployment_target = '10.15'
216-
ss.ios.deployment_target = '15.0'
216+
ss.tvos.deployment_target = '15.0'
217217
ss.watchos.deployment_target = '7.0'
218218
end
219219

FirebaseABTesting.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Firebase Cloud Messaging and Firebase Remote Config in your app.
2424

2525
ios.deployment_target = '15.0'
2626
osx_deployment_target = '10.15'
27-
ios.deployment_target = '15.0'
27+
tvos.deployment_target = '15.0'
2828
watchos_deployment_target = '7.0'
2929

3030
s.ios.deployment_target = ios_deployment_target

FirebaseAnalytics.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Pod::Spec.new do |s|
2121

2222
s.ios.deployment_target = '15.0'
2323
s.osx.deployment_target = '10.15'
24-
s.ios.deployment_target = '15.0'
24+
s.tvos.deployment_target = '15.0'
2525

2626
s.libraries = 'c++', 'sqlite3', 'z'
2727
s.frameworks = 'StoreKit'

FirebaseAppCheck.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Pod::Spec.new do |s|
1919

2020
ios.deployment_target = '15.0'
2121
osx_deployment_target = '10.15'
22-
ios.deployment_target = '15.0'
22+
tvos.deployment_target = '15.0'
2323
watchos_deployment_target = '7.0'
2424

2525
s.swift_version = '5.9'

FirebaseAppCheckInterop.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Pod::Spec.new do |s|
2323

2424
ios.deployment_target = '15.0'
2525
osx_deployment_target = '10.15'
26-
ios.deployment_target = '15.0'
26+
tvos_deployment_target = '15.0'
2727
watchos_deployment_target = '7.0'
2828

2929
s.ios.deployment_target = ios_deployment_target

FirebaseAuth.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ supports email and password accounts, as well as several 3rd party authenticatio
2121

2222
ios.deployment_target = '15.0'
2323
osx_deployment_target = '10.15'
24-
ios.deployment_target = '15.0'
24+
tvos_deployment_target = '15.0'
2525
watchos_deployment_target = '7.0'
2626

2727
s.swift_version = '5.9'

FirebaseAuthInterop.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Pod::Spec.new do |s|
2222
s.social_media_url = 'https://twitter.com/Firebase'
2323
s.ios.deployment_target = '15.0'
2424
s.osx.deployment_target = '10.15'
25-
s.ios.deployment_target = '15.0'
25+
s.tvos.deployment_target = '15.0'
2626
s.watchos.deployment_target = '7.0'
2727

2828
s.source_files = 'FirebaseAuth/Interop/**/*.[hm]'

FirebaseAuthTestingSupport.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Pod::Spec.new do |s|
1919

2020
ios.deployment_target = '15.0'
2121
osx_deployment_target = '10.15'
22-
ios.deployment_target = '15.0'
22+
tvos_deployment_target = '15.0'
2323
watchos_deployment_target = '7.0'
2424

2525
s.swift_version = '5.9'

FirebaseCombineSwift.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ for internal testing only. It should not be published.
2323

2424
ios.deployment_target = '15.0'
2525
osx_deployment_target = '10.15'
26-
ios.deployment_target = '15.0'
26+
tvos_deployment_target = '15.0'
2727
watchos_deployment_target = '7.0'
2828

2929
s.ios.deployment_target = ios_deployment_target

FirebaseCore.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
2020

2121
ios.deployment_target = '15.0'
2222
osx_deployment_target = '10.15'
23-
ios.deployment_target = '15.0'
23+
tvos_deployment_target = '15.0'
2424
watchos_deployment_target = '7.0'
2525

2626
s.ios.deployment_target = ios_deployment_target

0 commit comments

Comments
 (0)