change findNearest and min and max

Author: cherylEnkidu

Firestore/Swift/Source/ExprImpl.swift

@@ -384,31 +384,31 @@ public extension Expression {
   }
 
   func minimum() -> AggregateFunction {
-    return AggregateFunction("minimum", [self])
+    return AggregateFunction("min", [self])
   }
 
   func maximum() -> AggregateFunction {
-    return AggregateFunction("maximum", [self])
+    return AggregateFunction("max", [self])
   }
 
   // MARK: Logical min/max
 
   func logicalMaximum(_ expressions: [Expression]) -> FunctionExpression {
-    return FunctionExpression("logical_maximum", [self] + expressions)
+    return FunctionExpression("max", [self] + expressions)
   }
 
   func logicalMaximum(_ values: [Sendable]) -> FunctionExpression {
     let exprs = [self] + values.map { Helper.sendableToExpr($0) }
-    return FunctionExpression("logical_maximum", exprs)
+    return FunctionExpression("max", exprs)
   }
 
   func logicalMinimum(_ expressions: [Expression]) -> FunctionExpression {
-    return FunctionExpression("logical_minimum", [self] + expressions)
+    return FunctionExpression("min", [self] + expressions)
   }
 
   func logicalMinimum(_ values: [Sendable]) -> FunctionExpression {
     let exprs = [self] + values.map { Helper.sendableToExpr($0) }
-    return FunctionExpression("logical_minimum", exprs)
+    return FunctionExpression("min", exprs)
   }
 
   // MARK: Vector Operations

Firestore/Swift/Source/SwiftAPI/Pipeline/DistanceMeasure.swift

@@ -29,17 +29,11 @@ public struct DistanceMeasure: Sendable, Equatable, Hashable {
     case dotProduct = "dot_product"
   }
 
-  public static var euclidean: DistanceMeasure {
-    return self.init(kind: .euclidean)
-  }
+  public static let euclidean: DistanceMeasure = DistanceMeasure(kind: .euclidean)
 
-  public static var cosine: DistanceMeasure {
-    return self.init(kind: .cosine)
-  }
+  public static let cosine: DistanceMeasure = DistanceMeasure(kind: .cosine)
 
-  public static var dotProduct: DistanceMeasure {
-    return self.init(kind: .dotProduct)
-  }
+  public static let dotProduct: DistanceMeasure = DistanceMeasure(kind: .dotProduct)
 
   init(kind: Kind) {
     self.kind = kind

Firestore/Swift/Source/SwiftAPI/Pipeline/Ordering.swift

@@ -35,13 +35,9 @@ struct Direction: Sendable, Equatable, Hashable {
     case descending
   }
 
-  static var ascending: Direction {
-    return self.init(kind: .ascending, rawValue: "ascending")
-  }
+  static let ascending = Direction(kind: .ascending, rawValue: "ascending")
 
-  static var descending: Direction {
-    return self.init(kind: .descending, rawValue: "descending")
-  }
+  static let descending = Direction(kind: .descending, rawValue: "descending")
 
   init(kind: Kind, rawValue: String) {
     self.kind = kind

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -391,11 +391,11 @@ public struct Pipeline: @unchecked Sendable {
   ///
   /// ```swift
   /// // let pipeline: Pipeline = ... // Assume pipeline from a collection with vector embeddings.
-  /// let queryVector: [Double] = [0.1, 0.2, ..., 0.8] // Example query vector.
+  /// let queryVector = VectorValue([0.1, 0.2, ..., 0.8]) // Example query vector.
   /// let nearestNeighborsPipeline = pipeline.findNearest(
   ///   field: Field("embedding_field"),       // Field containing the vector.
   ///   vectorValue: queryVector,              // Query vector for comparison.
-  ///   distanceMeasure: .COSINE,              // Distance metric.
+  ///   distanceMeasure: .cosine,              // Distance metric.
   ///   limit: 10,                             // Return top 10 nearest neighbors.
   ///   distanceField: "similarityScore"       // Optional: field for distance score.
   /// )
@@ -404,13 +404,13 @@ public struct Pipeline: @unchecked Sendable {
   ///
   /// - Parameters:
   ///   - field: The `Field` containing vector embeddings.
-  ///   - vectorValue: An array of `Double` representing the query vector.
-  ///   - distanceMeasure: The `DistanceMeasure` (e.g., `.EUCLIDEAN`, `.COSINE`) for comparison.
+  ///   - vectorValue: A `VectorValue` instance representing the query vector.
+  ///   - distanceMeasure: The `DistanceMeasure` (e.g., `.euclidean`, `.cosine`) for comparison.
   ///   - limit: Optional. Maximum number of similar documents to return.
   ///   - distanceField: Optional. Name for a new field to store the calculated distance.
   /// - Returns: A new `Pipeline` object with this stage appended.
   public func findNearest(field: Field,
-                          vectorValue: [Double],
+                          vectorValue: VectorValue,
                           distanceMeasure: DistanceMeasure,
                           limit: Int? = nil,
                           distanceField: String? = nil) -> Pipeline {

Firestore/Swift/Source/SwiftAPI/Stages.swift

@@ -242,13 +242,13 @@ class FindNearest: Stage {
   let name: String = "findNearest"
   let bridge: StageBridge
   private var field: Field
-  private var vectorValue: [Double]
+  private var vectorValue: VectorValue
   private var distanceMeasure: DistanceMeasure
   private var limit: Int?
   private var distanceField: String?
 
   init(field: Field,
-       vectorValue: [Double],
+       vectorValue: VectorValue,
        distanceMeasure: DistanceMeasure,
        limit: Int? = nil,
        distanceField: String? = nil) {
@@ -259,7 +259,7 @@ class FindNearest: Stage {
     self.distanceField = distanceField
     bridge = FindNearestStageBridge(
       field: field.bridge as! FieldBridge,
-      vectorValue: VectorValue(vectorValue),
+      vectorValue: vectorValue,
       distanceMeasure: distanceMeasure.kind.rawValue,
       limit: limit as NSNumber?,
       distanceField: distanceField.map { Field($0).toBridge() } ?? nil

Firestore/Swift/Tests/Integration/PipelineApiTests.swift

@@ -203,7 +203,7 @@ final class PipelineApiTests: FSTIntegrationTestCase {
   func testFindNearestStage() async throws {
     _ = db.pipeline().collection("books").findNearest(
       field: Field("embedding"),
-      vectorValue: [5.0],
+      vectorValue: VectorValue([5.0]),
       distanceMeasure: .cosine,
       limit: 3)
   }

Firestore/Swift/Tests/Integration/PipelineTests.swift

@@ -1541,7 +1541,7 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
         .collection(collRef.path)
         .findNearest(
           field: Field("embedding"),
-          vectorValue: [10, 1, 3, 1, 2, 1, 1, 1, 1, 1],
+          vectorValue: VectorValue([10, 1, 3, 1, 2, 1, 1, 1, 1, 1]),
           distanceMeasure: measure, limit: 3
         )
         .select(["title"])
@@ -1569,7 +1569,7 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
       .collection(collRef.path)
       .findNearest(
         field: Field("embedding"),
-        vectorValue: [10, 1, 2, 1, 1, 1, 1, 1, 1, 1],
+        vectorValue: VectorValue([10, 1, 2, 1, 1, 1, 1, 1, 1, 1]),
         distanceMeasure: .euclidean, limit: 2,
         distanceField: "computedDistance"
       )