Skip to content

Commit efc8024

Browse files
authored
Bump travis to 12.5 (#8411)
1 parent c0df01d commit efc8024

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

.travis.yml

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
os: osx
2-
osx_image: xcode11
2+
osx_image: xcode12.5
33
language: objective-c
44
cache:
55
bundler: true
@@ -99,14 +99,6 @@ jobs:
9999
script:
100100
- travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseCrashlytics.podspec --platforms=ios
101101

102-
- stage: test
103-
env:
104-
- PROJECT=Firestore PLATFORM=iOS METHOD=xcodebuild
105-
before_install:
106-
- ./scripts/if_changed.sh ./scripts/install_prereqs.sh
107-
script:
108-
- travis_retry ./scripts/if_changed.sh ./scripts/build.sh $PROJECT $PLATFORM $METHOD
109-
110102
- stage: test
111103
env:
112104
- PROJECT=GoogleUtilitiesComponents METHOD=pod-lib-lint
@@ -153,18 +145,6 @@ jobs:
153145
script:
154146
- travis_retry ./CocoapodsIntegrationTest/scripts/build_with_environment.sh --gemfile=./CocoapodsIntegrationTest/TestEnvironments/${POD_CONFIG_DIR}/Gemfile --podfile=./CocoapodsIntegrationTest/TestEnvironments/${POD_CONFIG_DIR}/Podfile
155147

156-
allow_failures:
157-
# Run fuzz tests only on cron jobs.
158-
- stage: test
159-
# if: type = cron
160-
env:
161-
- PROJECT=Firestore PLATFORM=iOS METHOD=fuzz
162-
before_install:
163-
- ./scripts/install_prereqs.sh
164-
script:
165-
# The travis_wait is necessary because fuzzing runs for 40 minutes.
166-
- travis_wait 45 ./scripts/fuzzing_ci.sh
167-
168148
branches:
169149
only:
170150
- master

FirebaseAuth/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# 8.5.0
2+
- [fixed] Fixed an analyze issue introduced in Xcode 12.5. (#8411)
3+
14
# 8.2.0
25
- [fixed] Fixed analyze issues introduced in Xcode 12.5. (#8210)
36
- [fixed] Fixed a bug in the link with email link, Game Center, and phone auth flows. (#8196)

FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ - (nullable NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **_Nonnu
263263
} else {
264264
errorData = nil;
265265
}
266-
if (error != NULL) {
266+
if (error != NULL && errorData != nil) {
267267
NSError *jsonError;
268268
NSDictionary *errorDict = [NSJSONSerialization JSONObjectWithData:errorData
269269
options:0

0 commit comments

Comments
 (0)