Skip to content

Commit f205fa8

Browse files
authored
[vertex-ai] Disable google-app-id (#14493)
1 parent 3c7b987 commit f205fa8

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

FirebaseVertexAI/Sources/GenerativeAIService.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,10 @@ struct GenerativeAIService {
193193
urlRequest.setValue("Firebase \(authToken)", forHTTPHeaderField: "Authorization")
194194
}
195195

196-
if firebaseInfo.app.isDataCollectionDefaultEnabled {
197-
urlRequest.setValue(firebaseInfo.googleAppID, forHTTPHeaderField: "X-Firebase-AppId")
198-
}
196+
// TODO: wait for release approval.
197+
// if firebaseInfo.app.isDataCollectionDefaultEnabled {
198+
// urlRequest.setValue(firebaseInfo.googleAppID, forHTTPHeaderField: "X-Firebase-AppId")
199+
// }
199200

200201
let encoder = JSONEncoder()
201202
urlRequest.httpBody = try encoder.encode(request)

FirebaseVertexAI/Tests/Unit/GenerativeModelTests.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,8 +1515,9 @@ final class GenerativeModelTests: XCTestCase {
15151515
XCTAssert(apiClientTags.contains(GenerativeAIService.languageTag))
15161516
XCTAssert(apiClientTags.contains(GenerativeAIService.firebaseVersionTag))
15171517
XCTAssertEqual(request.value(forHTTPHeaderField: "X-Firebase-AppCheck"), appCheckToken)
1518-
let googleAppID = request.value(forHTTPHeaderField: "X-Firebase-AppId")
1519-
XCTAssertEqual(googleAppID, dataCollection ? "My app ID" : nil)
1518+
// TODO: Wait for release approval
1519+
// let googleAppID = request.value(forHTTPHeaderField: "X-Firebase-AppId")
1520+
// XCTAssertEqual(googleAppID, dataCollection ? "My app ID" : nil)
15201521
if let authToken {
15211522
XCTAssertEqual(request.value(forHTTPHeaderField: "Authorization"), "Firebase \(authToken)")
15221523
} else {

0 commit comments

Comments
 (0)