[Infra] Convert FirebaseAnalyticsOnDeviceConversion JSON podspec to Ruby (#9785)

* Rename FirebaseAnalyticsOnDeviceConversion.podspec.json to FirebaseAnalyticsOnDeviceConversion.podspec

* Convert JSON podspec to ruby

* Directly translate dep versioning

* Remove trailing whitespace

* Update FirebaseManifest.swift

* Update .github/workflows/analytics.yml

* Updat Dangerfile

* This maybe works?

* It pretty much worked

* Revert FirebaseAnalyticsSwift/Sources/Analytics+SwiftUI.swift

* Fix CI

Author: ncooke3

.github/workflows/analytics.yml

@@ -3,9 +3,8 @@ name: analytics
 on:
   pull_request:
     paths:
-    - 'FirebaseAnalytics.podspec.json'
-    - 'FirebaseAnalyticsSwift**'
-    - 'GoogleAppMeasurement.podspec.json'
+    - 'FirebaseAnalytics**'
+    - 'GoogleAppMeasurement**'
     - '.github/workflows/analytics.yml'
     - 'Gemfile*'
   schedule:
@@ -37,6 +36,11 @@ jobs:
       run: scripts/third_party/travis/retry.sh pod spec lint GoogleAppMeasurement.podspec.json --platforms=${{ matrix.target }} --sources=https://github.com/firebase/SpecsDev.git,https://github.com/firebase/SpecsStaging.git,https://cdn.cocoapods.org/
     - name: FirebaseAnalyticsSwift
       run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseAnalyticsSwift.podspec --platforms=${{ matrix.target }}
+    # The following steps are only run on `ios` due to product availability.
+    - name: GoogleAppMeasurementOnDeviceConversion
+      run: scripts/third_party/travis/retry.sh pod spec lint GoogleAppMeasurementOnDeviceConversion.podspec.json --platforms=ios --sources=https://github.com/firebase/SpecsDev.git,https://github.com/firebase/SpecsStaging.git,https://cdn.cocoapods.org/
+    - name: FirebaseAnalyticsOnDeviceConversion
+      run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseAnalyticsOnDeviceConversion.podspec --platforms=ios
 
 # TODO: Consider pushing GoogleAppMeasurement.podspec.json to SpecsDev to enable similar test
 # for FirebaseAnalytics.podspec.json

Dangerfile

@@ -35,6 +35,7 @@ end
 # multiple directories may have multiple labels.
 def labelsForModifiedFiles()
   labels = []
+  labels.push("api: analytics") if @has_analytics_changes
   labels.push("api: abtesting") if @has_abtesting_changes
   labels.push("api: appcheck") if @has_appcheck_changes
   labels.push("api: appdistribution") if @has_appdistribution_changes
@@ -70,6 +71,18 @@ has_changelog_changes = hasChangesIn(["CHANGELOG"])
 has_license_changes = didModify(["LICENSE"])
 
 ## Product directories
+@has_analytics_changes = hasChangesIn([
+  "FirebaseAnalyticsOnDeviceConversionWrapper",
+  "FirebaseAnalyticsSwift",
+  "FirebaseAnalyticsWithoutAdIdSupportWrapper",
+  "FirebaseAnalyticsWrapper"
+]) || didModify([
+  "FirebaseAnalytics.podspec.json",
+  "FirebaseAnalyticsSwift.podspec",
+  "FirebaseAnalyticsOnDeviceConversion.podspec",
+  "GoogleAppMeasurement.podspec.json",
+  "GoogleAppMeasurementOnDeviceConversion.podspec.json"
+])
 @has_abtesting_changes = hasChangesIn("FirebaseABTesting")
 @has_abtesting_api_changes = hasChangesIn("FirebaseABTesting/Sources/Public/")
 @has_appcheck_changes = hasChangesIn("FirebaseAppCheck")

FirebaseAnalyticsOnDeviceConversion.podspec

@@ -0,0 +1,28 @@
+Pod::Spec.new do |s|
+    s.name             = 'FirebaseAnalyticsOnDeviceConversion'
+    s.version          = '9.0.0'
+    s.summary          = 'On device conversion measurement plugin for FirebaseAnalytics. Not intended for direct use.'
+
+    s.description      = <<-DESC
+    On device conversion measurement plugin for FirebaseAnalytics. This pod does not expose any headers and isn't intended for direct use, but rather as a plugin of FirebaseAnalytics.
+                         DESC
+
+    s.homepage         = 'https://firebase.google.com/features/analytics/'
+    s.license          = { :type => 'Copyright', :text => 'Copyright 2022 Google' }
+    s.authors          = 'Google, Inc.'
+
+    s.source           = {
+      :git => 'https://github.com/firebase/firebase-ios-sdk.git',
+      :tag => 'CocoaPods-' + s.version.to_s
+    }
+
+    s.cocoapods_version = '>= 1.10.2'
+
+    s.dependency 'GoogleAppMeasurementOnDeviceConversion', '9.0'
+
+    s.static_framework = true
+
+    s.ios.deployment_target = '10.0'
+
+    s.source_files = 'FirebaseAnalyticsOnDeviceConversionWrapper/*'
+end

FirebaseAnalyticsOnDeviceConversion.podspec.json

@@ -35,7 +35,7 @@ public let shared = Manifest(
     Pod("GoogleAppMeasurement", isClosedSource: true),
     Pod("GoogleAppMeasurementOnDeviceConversion", isClosedSource: true, platforms: ["ios"]),
     Pod("FirebaseAnalytics", isClosedSource: true),
-    Pod("FirebaseAnalyticsOnDeviceConversion", isClosedSource: true, platforms: ["ios"], zip: true),
+    Pod("FirebaseAnalyticsOnDeviceConversion", platforms: ["ios"], zip: true),
     Pod("FirebaseAnalyticsSwift", zip: true),
     Pod("FirebaseABTesting", zip: true),
     Pod("FirebaseAppCheck", zip: true),