Skip to content

Commit f42d423

Browse files
committed
add comments
1 parent fadcd65 commit f42d423

File tree

1 file changed

+13
-19
lines changed

1 file changed

+13
-19
lines changed

.github/workflows/common_quickstart.yml

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,15 @@ on:
77
workflow_call:
88
# Re-usable workflows do not automatically inherit the caller's secrets.
99
#
10-
# If the calling workflow uses a secret in the `setup_command` input, then
11-
# it also must pass the secret to the re-usable workflow.
10+
# This workflow decrypts encrypted files, so the calling workflow needs to
11+
# pass the secret to the re-usable workflow.
1212
#
1313
# Example:
1414
#
15-
# pod_lib_lint:
16-
# uses: ./.github/workflows/common_cocoapods.yml
15+
# quickstart:
16+
# uses: ./.github/workflows/common_quickstart.yml
1717
# with:
18-
# product: FirebaseFoo
19-
# setup_command: |
20-
# scripts/decrypt_gha_secret.sh \
21-
# /path/to/GoogleService-Info.plist.gpg \
22-
# /path/to/dest/GoogleService-Info.plist "$plist_secret"
18+
# # ...
2319
# secrets:
2420
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
2521
#
@@ -28,45 +24,42 @@ on:
2824
required: true
2925

3026
inputs:
31-
# The product to test be tested (e.g. `FirebaseABTesting`).
27+
# The product to test be tested (e.g. `ABTesting`).
3228
product:
3329
type: string
3430
required: true
3531

36-
# TODO: What does this mean?
32+
# TODO(docs): What does this mean?
3733
is_legacy:
3834
type: boolean
3935
required: true
4036

37+
# TODO(docs):
4138
plist_src_path:
4239
type: string
4340
required: true
4441

42+
# TODO(docs):
4543
plist_dst_path:
4644
type: string
4745
required: true
4846

47+
# TODO(docs):
4948
# swift or objc
5049
quickstart_type:
5150
type: string
5251
required: false
5352
default: objc
5453

54+
# TODO(docs):
5555
run_tests:
5656
type: boolean
5757
required: false
5858
default: true
5959

6060
# A command to execute before testing.
6161
#
62-
# This is useful for additional set up, like starting an emulator or
63-
# downloading test data.
64-
#
65-
# Note, this step has an env var set to decrypt plists. Use
66-
# "$plist_secret" in the given command. See `secrets` documentation
67-
# at top of this file.
68-
#
69-
# Example: `FirebaseFunctions/Backend/start.sh synchronous`
62+
# Example: `scripts/setup_quickstart.sh functions`
7063
setup_command:
7164
type: string
7265
required: false
@@ -108,6 +101,7 @@ jobs:
108101
${{ inputs.run_tests }} \
109102
${{ inputs.quickstart_type }}
110103
# TODO: Add upload on fialure.
104+
# TODO: Remove the decrypted repo secret.
111105
# - name: Upload raw logs if failed.
112106
# if: ${{ failure() }}
113107
# uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)