[App Distribution] Reset sign in flag on unauthorized error (#8270)

* [App Distribution] Reset sign in flag on unauthorized error

* Fix formatting and update CHANGELOG

Author: rachaprince

FirebaseAppDistribution/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+- [changed] Sign out the Tester when the call to fetch releases fails with an unauthorized error (#8270).
+
 # v7.3.0-beta
 - [changed] Sign out the Tester when the call to fetch releases fails with an unauthenticated error.
 - [fixed] Crash caused by trying to parse response as JSON when response is nil (#6996).

FirebaseAppDistribution/Sources/FIRAppDistribution.m

@@ -252,6 +252,10 @@ - (void)fetchNewLatestRelease:(void (^)(FIRAppDistributionRelease *_Nullable rel
             FIRFADErrorLog(@"Tester authentication failed when fetching releases. Tester will need "
                            @"to sign in again.");
             [self signOutTester];
+          } else if ([error code] == FIRFADApiErrorUnauthorized) {
+            FIRFADErrorLog(@"Tester is not authorized to view releases for this app. Tester will "
+                           @"need to sign in again.");
+            [self signOutTester];
           }
 
           dispatch_async(dispatch_get_main_queue(), ^{

FirebaseAppDistribution/Tests/Unit/FIRAppDistributionTests.m

@@ -382,6 +382,33 @@ - (void)testFetchNewLatestReleaseUnauthenticatedFailure {
   OCMReject([_mockMachO codeHash]);
 }
 
+- (void)testFetchNewLatestReleaseUnauthorizedFailure {
+  NSError *mockError =
+      [NSError errorWithDomain:kFIRFADApiErrorDomain
+                          code:FIRFADApiErrorUnauthorized
+                      userInfo:@{NSLocalizedDescriptionKey : @"This is unfortunate."}];
+  [self mockFetchReleasesCompletion:nil error:mockError];
+  OCMStub([_mockMachO codeHash]).andReturn(@"this-is-old");
+  [[GULUserDefaults standardUserDefaults] setBool:YES forKey:@"FIRFADSignInState"];
+  XCTAssertTrue([[self appDistribution] isTesterSignedIn]);
+
+  XCTestExpectation *expectation = [self expectationWithDescription:@"Fetch latest release fails."];
+
+  [[self appDistribution] fetchNewLatestRelease:^(FIRAppDistributionRelease *_Nullable release,
+                                                  NSError *_Nullable error) {
+    XCTAssertNil(release);
+    XCTAssertNotNil(error);
+    XCTAssertEqual([error code], FIRAppDistributionErrorAuthenticationFailure);
+    XCTAssertEqual([error domain], FIRAppDistributionErrorDomain);
+    XCTAssertFalse([[self appDistribution] isTesterSignedIn]);
+    [expectation fulfill];
+  }];
+
+  [self waitForExpectations:@[ expectation ] timeout:5.0];
+  [self verifyFetchReleasesCompletion];
+  OCMReject([_mockMachO codeHash]);
+}
+
 - (void)testCheckForUpdateWithCompletionTesterSignedIn {
   [self mockInstallationIdCompletion:_mockInstallationId error:nil];
   [self mockUIServiceRegistrationCompletion:nil];