Build all sources with CMake (#4159)

* Fix field initialization order

* Reduce dependencies in objc_compatibility_apple_test

This makes it possible to build and test util without having to build
everything

* Add a lint check for CMake files

* Find XCTest, if available

* Fix CMakeLists.txt to include all sources

* Fix test flake in local store tests

This doesn't affect production because we always set the additional
references pointer there, but it's technically optional and some tests
don't do this.

Author: wilhuff

CMakeLists.txt

@@ -210,6 +210,14 @@ target_include_directories(
 )
 
 
+# XCTest
+if(${CMAKE_VERSION} VERSION_LESS "3.3.0")
+  set(XCTest_FOUND OFF)
+else()
+  find_package(XCTest)
+endif()
+
+
 enable_testing()
 include(compiler_setup)
 

Firestore/Source/CMakeLists.txt

@@ -12,4 +12,82 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-add_subdirectory(Public)
+if(APPLE)
+  podspec_version(firestore_version ${PROJECT_SOURCE_DIR}/FirebaseFirestore.podspec)
+
+  cc_library(
+    firebase_firestore_objc_api
+    SOURCES
+      API/FIRCollectionReference+Internal.h
+      API/FIRCollectionReference.mm
+      API/FIRDocumentChange+Internal.h
+      API/FIRDocumentChange.mm
+      API/FIRDocumentReference+Internal.h
+      API/FIRDocumentReference.mm
+      API/FIRDocumentSnapshot+Internal.h
+      API/FIRDocumentSnapshot.mm
+      API/FIRFieldPath+Internal.h
+      API/FIRFieldPath.mm
+      API/FIRFieldValue+Internal.h
+      API/FIRFieldValue.mm
+      API/FIRFirestore+Internal.h
+      API/FIRFirestore.mm
+      API/FIRFirestoreSettings+Internal.h
+      API/FIRFirestoreSettings.mm
+      API/FIRFirestoreSource+Internal.h
+      API/FIRFirestoreSource.mm
+      API/FIRFirestoreVersion.h
+      API/FIRFirestoreVersion.mm
+      API/FIRGeoPoint+Internal.h
+      API/FIRGeoPoint.mm
+      API/FIRListenerRegistration+Internal.h
+      API/FIRListenerRegistration.mm
+      API/FIRQuery+Internal.h
+      API/FIRQuery.mm
+      API/FIRQuerySnapshot+Internal.h
+      API/FIRQuerySnapshot.mm
+      API/FIRSnapshotMetadata+Internal.h
+      API/FIRSnapshotMetadata.mm
+      API/FIRTimestamp+Internal.h
+      API/FIRTransaction+Internal.h
+      API/FIRTransaction.mm
+      API/FIRWriteBatch+Internal.h
+      API/FIRWriteBatch.mm
+      API/FSTFirestoreComponent.h
+      API/FSTFirestoreComponent.mm
+      API/FSTUserDataConverter.h
+      API/FSTUserDataConverter.mm
+      API/converters.h
+      API/converters.mm
+      Core/FSTTypes.h
+      Public/FIRCollectionReference.h
+      Public/FIRDocumentChange.h
+      Public/FIRDocumentReference.h
+      Public/FIRDocumentSnapshot.h
+      Public/FIRFieldPath.h
+      Public/FIRFieldValue.h
+      Public/FIRFirestore.h
+      Public/FIRFirestoreErrors.h
+      Public/FIRFirestoreSettings.h
+      Public/FIRFirestoreSource.h
+      Public/FIRGeoPoint.h
+      Public/FIRListenerRegistration.h
+      Public/FIRQuery.h
+      Public/FIRQuerySnapshot.h
+      Public/FIRSnapshotMetadata.h
+      Public/FIRTimestamp.h
+      Public/FIRTransaction.h
+      Public/FIRWriteBatch.h
+      Public/FirebaseFirestore.h
+      Util/FSTClasses.h
+    DEPENDS
+      absl_strings
+      firebase_firestore_api
+  )
+
+  target_include_directories(
+    firebase_firestore_objc_api
+    PUBLIC
+    ${FIREBASE_SOURCE_DIR}/Firestore/Source/Public
+  )
+endif()

Firestore/core/CMakeLists.txt

@@ -28,6 +28,7 @@ add_subdirectory(src/firebase/firestore/util)
 
 add_subdirectory(test/firebase/firestore/testutil)
 add_subdirectory(test/firebase/firestore)
+add_subdirectory(test/firebase/firestore/api)
 add_subdirectory(test/firebase/firestore/auth)
 add_subdirectory(test/firebase/firestore/core)
 add_subdirectory(test/firebase/firestore/immutable)

Firestore/core/include/firebase/firestore/CMakeLists.txt

@@ -17,6 +17,7 @@
 # issue tracker: https://gitlab.kitware.com/cmake/cmake/issues/15234)
 add_custom_target(firebase_firestore_types_ide SOURCES
     firestore_errors.h
+    firestore_version.h
     geo_point.h
     timestamp.h
 )

Firestore/core/src/firebase/firestore/api/CMakeLists.txt

@@ -17,22 +17,34 @@ cc_library(
   SOURCES
     collection_reference.cc
     collection_reference.h
-    collection_reference.cc
     document_change.cc
     document_change.h
+    document_reference.h
+    document_reference.mm
     document_snapshot.cc
     document_snapshot.h
+    firestore.h
+    firestore.mm
+    listener_registration.h
     query_core.h
     query_core.mm
+    query_listener_registration.h
+    query_listener_registration.mm
     query_snapshot.cc
     query_snapshot.h
     settings.cc
     settings.h
     snapshot_metadata.cc
     snapshot_metadata.h
+    snapshots_in_sync_listener_registration.h
+    snapshots_in_sync_listener_registration.mm
+    source.h
+    write_batch.h
+    write_batch.mm
   DEPENDS
     absl_meta
     firebase_firestore_core
+    firebase_firestore_local
     firebase_firestore_model
     firebase_firestore_util
 )

Firestore/core/src/firebase/firestore/core/CMakeLists.txt

@@ -25,10 +25,15 @@ cc_library(
     database_info.h
     direction.cc
     direction.h
+    event_listener.h
+    event_manager.h
+    event_manager.mm
     field_filter.cc
     field_filter.h
     filter.cc
     filter.h
+    firestore_client.h
+    firestore_client.mm
     in_filter.cc
     in_filter.h
     key_field_in_filter.cc
@@ -43,8 +48,15 @@ cc_library(
     query.h
     query_listener.cc
     query_listener.h
+    sync_engine.h
+    sync_engine.mm
+    sync_engine_callback.h
     target_id_generator.cc
     target_id_generator.h
+    transaction.h
+    transaction.mm
+    transaction_runner.h
+    transaction_runner.mm
     user_data.cc
     user_data.h
     view.cc
@@ -53,6 +65,7 @@ cc_library(
     view_snapshot.h
   DEPENDS
     absl_strings
+    firebase_firestore_local
     firebase_firestore_model
     firebase_firestore_objc
     firebase_firestore_remote

Firestore/core/src/firebase/firestore/local/CMakeLists.txt

@@ -68,8 +68,11 @@ cc_library(
     local_documents_view.h
     local_serializer.cc
     local_serializer.h
+    local_store.cc
+    local_store.h
     local_view_changes.cc
     local_view_changes.h
+    local_write_result.h
     lru_garbage_collector.cc
     lru_garbage_collector.h
     memory_eager_reference_delegate.cc

Firestore/core/src/firebase/firestore/local/memory_eager_reference_delegate.h

@@ -60,10 +60,10 @@ class MemoryEagerReferenceDelegate : public ReferenceDelegate {
       orphaned_;
 
   // This instance is owned by MemoryPersistence.
-  MemoryPersistence* persistence_;
+  MemoryPersistence* persistence_ = nullptr;
 
   // The ReferenceSet is owned by LocalStore.
-  ReferenceSet* additional_references_;
+  ReferenceSet* additional_references_ = nullptr;
 };
 
 }  // namespace local

Firestore/core/src/firebase/firestore/nanopb/CMakeLists.txt

@@ -17,6 +17,7 @@ cc_library(
   SOURCES
     byte_string.cc
     byte_string.h
+    fields_array.h
     message.cc
     message.h
     nanopb_util.cc

Firestore/core/src/firebase/firestore/remote/CMakeLists.txt

@@ -21,6 +21,7 @@ cc_library(
   DEPENDS
     absl_base
     firebase_firestore_util
+    "-framework SystemConfiguration"
   EXCLUDE_FROM_ALL
 )
 
@@ -46,21 +47,28 @@ cc_select(
 # alongside gRPC and is necessary to establish SSL connections. Embed this file
 # into the binary by converting it to a char array.
 add_custom_command(
-    OUTPUT grpc_root_certificates_generated.h grpc_root_certificates_generated.cc
-    COMMAND python ${FIREBASE_SOURCE_DIR}/scripts/binary_to_array.py
-        --output_header=grpc_root_certificates_generated.h
-        --output_source=grpc_root_certificates_generated.cc
-        --cpp_namespace=firebase::firestore::remote
-        --array=grpc_root_certificates_generated_data
-        --array_size=grpc_root_certificates_generated_size
-        ${FIREBASE_EXTERNAL_SOURCE_DIR}/grpc/etc/roots.pem
-    DEPENDS
+  OUTPUT
+    grpc_root_certificates_generated.h  # NOLINT(generated)
+    grpc_root_certificates_generated.cc # NOLINT(generated)
+  COMMAND python ${FIREBASE_SOURCE_DIR}/scripts/binary_to_array.py
+      --output_header=grpc_root_certificates_generated.h
+      --output_source=grpc_root_certificates_generated.cc
+      --cpp_namespace=firebase::firestore::remote
+      --array=grpc_root_certificates_generated_data
+      --array_size=grpc_root_certificates_generated_size
+      ${FIREBASE_EXTERNAL_SOURCE_DIR}/grpc/etc/roots.pem
+  DEPENDS
     ${FIREBASE_EXTERNAL_SOURCE_DIR}/grpc/etc/roots.pem
 )
 
+# TODO(wilhuff): Build grpc_root_certificate_finder_apple.mm NOLINT(not built)
+
 cc_library(
   firebase_firestore_remote
   SOURCES
+    datastore.cc
+    datastore.h
+    existence_filter.h
     exponential_backoff.cc
     exponential_backoff.h
     grpc_call.h
@@ -84,25 +92,24 @@ cc_library(
     grpc_util.cc
     grpc_util.cc
     grpc_util.h
+    online_state_tracker.cc
+    online_state_tracker.h
     remote_event.cc
     remote_event.h
+    remote_objc_bridge.h
+    remote_objc_bridge.mm
+    remote_store.cc
+    remote_store.h
     serializer.cc
     serializer.h
+    stream.cc
+    stream.h
     watch_change.cc
     watch_change.h
-
-    # TODO(varconst): add these files once they no longer depend on Objective-C
-    # serializer.
-    # datastore.h
-    # datastore.cc
-    # remote_objc_bridge.h
-    # remote_objc_bridge.mm
-    # stream.h
-    # stream.cc
-    # watch_stream.h
-    # watch_stream.cc
-    # write_stream.h
-    # write_stream.cc
+    watch_stream.cc
+    watch_stream.h
+    write_stream.cc
+    write_stream.h
 
   DEPENDS
     # TODO(b/111328563) Force nanopb first to work around ODR violations