Skip to content

Commit fcba5a2

Browse files
authored
Fix Auth post-submit CI build break (#3061)
1 parent 2c03297 commit fcba5a2

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

Example/Auth/Sample/FacebookAuthProvider.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ - (void)getAuthCredentialWithPresentingViewController:(UIViewController *)viewCo
4949

5050
[ApplicationDelegate setOpenURLDelegate:self];
5151
[FBSDKSettings setAppID:kFacebookAppID];
52-
[_loginManager logInWithReadPermissions:@[ @"email" ]
53-
fromViewController:viewController
54-
handler:^(FBSDKLoginManagerLoginResult *result, NSError *error) {
52+
[_loginManager logInWithPermissions:@[ @"email" ]
53+
fromViewController:viewController
54+
handler:^(FBSDKLoginManagerLoginResult *result, NSError *error) {
5555
[ApplicationDelegate setOpenURLDelegate:nil];
5656
if (!error && result.isCancelled) {
5757
error = [NSError errorWithDomain:@"com.google.FirebaseAuthSample" code:-1 userInfo:nil];

scripts/build.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,9 @@ case "$product-$method-$platform" in
199199
# Code Coverage collection is only working on iOS currently.
200200
./scripts/collect_metrics.sh 'Example/Firebase.xcworkspace' "AllUnitTests_$platform"
201201

202-
# Run integration tests (not allowed on PRs)
203-
if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then
202+
# Run integration tests (not allowed on forks)
203+
if [[ "$TRAVIS_PULL_REQUEST" == "false" ||
204+
"$TRAVIS_PULL_REQUEST_SLUG" == "$TRAVIS_REPO_SLUG" ]]; then
204205
RunXcodebuild \
205206
-workspace 'Example/Firebase.xcworkspace' \
206207
-scheme "Auth_ApiTests" \

0 commit comments

Comments
 (0)