Skip to content

Commit fd08687

Browse files
ncooke3ncooke3
authored
chore(ci): Work on retry logic
1 parent 52ae69a commit fd08687

File tree

1 file changed

+100
-97
lines changed

1 file changed

+100
-97
lines changed

‎.github/workflows/storage.yml‎

Lines changed: 100 additions & 97 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,24 @@ concurrency:
2424
cancel-in-progress: true
2525

2626
jobs:
27-
spm:
28-
uses: ./.github/workflows/common.yml
29-
with:
30-
target: FirebaseStorageUnit
27+
# spm:
28+
# uses: ./.github/workflows/common.yml
29+
# with:
30+
# target: FirebaseStorageUnit
3131

32-
catalyst:
33-
uses: ./.github/workflows/common_catalyst.yml
34-
with:
35-
product: FirebaseStorage
36-
target: FirebaseStorage-Unit-unit
32+
# catalyst:
33+
# uses: ./.github/workflows/common_catalyst.yml
34+
# with:
35+
# product: FirebaseStorage
36+
# target: FirebaseStorage-Unit-unit
3737

3838
storage-integration-tests:
3939
# Don't run on private repo unless it is a PR.
4040
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
4141
strategy:
4242
matrix:
43-
language: [Swift, ObjC]
43+
# language: [Swift, ObjC]
44+
language: [ObjC]
4445
include:
4546
- os: macos-15
4647
xcode: Xcode_16.4
@@ -71,97 +72,99 @@ jobs:
7172
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
7273
- uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
7374
with:
74-
timeout_minutes: 120
75+
# timeout_minutes: 120
76+
timeout_seconds: 1
7577
max_attempts: 3
7678
retry_on: error
77-
retry_wait_seconds: 120
79+
# retry_wait_seconds: 120
80+
retry_wait_seconds: 1
7881
command: ([ -z $plist_secret ] || scripts/build.sh Storage${{ matrix.language }} all)
7982

80-
quickstart:
81-
# Don't run on private repo unless it is a PR.
82-
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
83-
# TODO: See #12399 and restore Objective-C testing for Xcode 15 if GHA is fixed.
84-
strategy:
85-
matrix:
86-
include:
87-
#- os: macos-13
88-
# xcode: Xcode_14.2 # TODO: the legacy ObjC quickstart doesn't build with Xcode 15.
89-
- swift: swift
90-
os: macos-15
91-
xcode: Xcode_16.4
92-
env:
93-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
94-
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
95-
LEGACY: true
96-
runs-on: ${{ matrix.os }}
97-
steps:
98-
- uses: actions/checkout@v4
99-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
100-
- name: Setup quickstart
101-
run: scripts/setup_quickstart.sh storage
102-
- name: Install Secret GoogleService-Info.plist
103-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
104-
quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
105-
- name: Xcode
106-
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
107-
- name: Test quickstart
108-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Storage false ${{ matrix.swift }})
83+
# quickstart:
84+
# # Don't run on private repo unless it is a PR.
85+
# if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
86+
# # TODO: See #12399 and restore Objective-C testing for Xcode 15 if GHA is fixed.
87+
# strategy:
88+
# matrix:
89+
# include:
90+
# #- os: macos-13
91+
# # xcode: Xcode_14.2 # TODO: the legacy ObjC quickstart doesn't build with Xcode 15.
92+
# - swift: swift
93+
# os: macos-15
94+
# xcode: Xcode_16.4
95+
# env:
96+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
97+
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
98+
# LEGACY: true
99+
# runs-on: ${{ matrix.os }}
100+
# steps:
101+
# - uses: actions/checkout@v4
102+
# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
103+
# - name: Setup quickstart
104+
# run: scripts/setup_quickstart.sh storage
105+
# - name: Install Secret GoogleService-Info.plist
106+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
107+
# quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
108+
# - name: Xcode
109+
# run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
110+
# - name: Test quickstart
111+
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart.sh Storage false ${{ matrix.swift }})
109112

110-
quickstart-ftl-cron-only:
111-
# Don't run on private repo.
112-
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
113-
env:
114-
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
115-
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
116-
LEGACY: true
117-
runs-on: macos-15
118-
steps:
119-
- uses: actions/checkout@v4
120-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
121-
- uses: actions/setup-python@v5
122-
with:
123-
python-version: '3.11'
124-
- name: Setup quickstart
125-
run: scripts/setup_quickstart.sh storage
126-
- name: Install Secret GoogleService-Info.plist
127-
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
128-
quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
129-
# - name: Build objc quickstart
130-
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Storage)
131-
- name: Build swift quickstart
132-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Storage swift)
133-
- id: ftl_test
134-
uses: FirebaseExtended/github-actions/[email protected]
135-
with:
136-
credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
137-
testapp_dir: quickstart-ios/build-for-testing
138-
test_type: "xctest"
113+
# quickstart-ftl-cron-only:
114+
# # Don't run on private repo.
115+
# if: github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule'
116+
# env:
117+
# plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
118+
# signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
119+
# LEGACY: true
120+
# runs-on: macos-15
121+
# steps:
122+
# - uses: actions/checkout@v4
123+
# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
124+
# - uses: actions/setup-python@v5
125+
# with:
126+
# python-version: '3.11'
127+
# - name: Setup quickstart
128+
# run: scripts/setup_quickstart.sh storage
129+
# - name: Install Secret GoogleService-Info.plist
130+
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-storage.plist.gpg \
131+
# quickstart-ios/storage/GoogleService-Info.plist "$plist_secret"
132+
# # - name: Build objc quickstart
133+
# # run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Storage)
134+
# - name: Build swift quickstart
135+
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Storage swift)
136+
# - id: ftl_test
137+
# uses: FirebaseExtended/github-actions/[email protected]
138+
# with:
139+
# credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
140+
# testapp_dir: quickstart-ios/build-for-testing
141+
# test_type: "xctest"
139142

140-
pod_lib_lint:
141-
uses: ./.github/workflows/common_cocoapods.yml
142-
with:
143-
product: FirebaseStorage
144-
test_specs: unit
143+
# pod_lib_lint:
144+
# uses: ./.github/workflows/common_cocoapods.yml
145+
# with:
146+
# product: FirebaseStorage
147+
# test_specs: unit
145148

146-
storage-cron-only:
147-
# Don't run on private repo.
148-
if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
149-
strategy:
150-
matrix:
151-
target: [ios, tvos, macos, watchos]
152-
build-env:
153-
- os: macos-14
154-
xcode: Xcode_16.2
155-
- os: macos-15
156-
xcode: Xcode_16.4
157-
runs-on: ${{ matrix.build-env.os }}
158-
needs: pod_lib_lint
159-
steps:
160-
- uses: actions/checkout@v4
161-
- uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
162-
- name: Setup Bundler
163-
run: scripts/setup_bundler.sh
164-
- name: Xcode
165-
run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer
166-
- name: PodLibLint Storage Cron
167-
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseStorage.podspec --platforms=${{ matrix.target }} --use-static-frameworks --skip-tests
149+
# storage-cron-only:
150+
# # Don't run on private repo.
151+
# if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
152+
# strategy:
153+
# matrix:
154+
# target: [ios, tvos, macos, watchos]
155+
# build-env:
156+
# - os: macos-14
157+
# xcode: Xcode_16.2
158+
# - os: macos-15
159+
# xcode: Xcode_16.4
160+
# runs-on: ${{ matrix.build-env.os }}
161+
# needs: pod_lib_lint
162+
# steps:
163+
# - uses: actions/checkout@v4
164+
# - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
165+
# - name: Setup Bundler
166+
# run: scripts/setup_bundler.sh
167+
# - name: Xcode
168+
# run: sudo xcode-select -s /Applications/${{ matrix.build-env.xcode }}.app/Contents/Developer
169+
# - name: PodLibLint Storage Cron
170+
# run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseStorage.podspec --platforms=${{ matrix.target }} --use-static-frameworks --skip-tests

0 commit comments

Comments
 (0)