Prepare for macOS test support (#2623)

* Add deployment targets for osx

* Fix bundle path to make spec tests work

On iOS, resources are directly within the bundle so the bundlePath and
the resourcePath are the same.

On macOS, resources are in a Contents/Resources subfolder so enumerating
from bundlePath causes us to look for names like
Contents/Resources/offline_spec_test, which doesn't work.

* Fix documentation warnings that show up under the macOS build

Author: wilhuff

Firestore/Example/GoogleBenchmark.podspec

@@ -34,6 +34,8 @@ Google's C++ benchmark framework.
   }
 
   s.ios.deployment_target = '8.0'
+  s.osx.deployment_target = '10.10'
+
   s.requires_arc = false
 
   s.public_header_files = [

Firestore/Example/GoogleTest.podspec

@@ -34,6 +34,8 @@ Google's C++ test framework.
   }
 
   s.ios.deployment_target = '8.0'
+  s.osx.deployment_target = '10.10'
+
   s.requires_arc = false
 
   # Exclude include/gtest/internal/custom files from public headers. These

Firestore/Example/LibFuzzer.podspec

@@ -31,6 +31,7 @@ Pod::Spec.new do |s|
   # LibFuzzer uses thread_local which does not appear to be supported before
   # iOS 9.
   s.ios.deployment_target = '9.0'
+  s.osx.deployment_target = '10.10'
 
   # Check out only libFuzzer folder.
   s.source              = {

Firestore/Example/ProtobufCpp.podspec

@@ -29,6 +29,9 @@ Pod::Spec.new do |s|
     :tag => "v#{s.version}"
   }
 
+  s.ios.deployment_target = '8.0'
+  s.osx.deployment_target = '10.10'
+
   s.source_files = 'src/**/*.{h,cc}'
   s.exclude_files = # skip test files. (Yes, the test files are intermixed with
                     # the source. No there doesn't seem to be a common/simple

Firestore/Example/Tests/SpecTests/FSTSpecTests.mm

@@ -728,7 +728,7 @@ - (void)testSpecTests {
   NSBundle *bundle = [NSBundle bundleForClass:[self class]];
   NSFileManager *fs = [NSFileManager defaultManager];
   BOOL exclusiveMode = NO;
-  for (NSString *file in [fs enumeratorAtPath:[bundle bundlePath]]) {
+  for (NSString *file in [fs enumeratorAtPath:[bundle resourcePath]]) {
     if (![@"json" isEqual:[file pathExtension]]) {
       continue;
     }

Firestore/core/test/firebase/firestore/FSTGoogleTestTests.mm

@@ -50,7 +50,7 @@ @interface GoogleTests : XCTestCase
 
 // If the user focuses on GoogleTests itself, this means force all C++ tests to
 // run.
-BOOL forceAllTests = NO;
+bool forceAllTests = false;
 
 /**
  * Loads this XCTest runner's configuration file and figures out which tests to
@@ -216,7 +216,7 @@ void ReportTestResult(XCTestCase *self, SEL _cmd) {
                               atLine:(part.line_number() > 0
                                           ? part.line_number()
                                           : 0)
-                            expected:YES];
+                            expected:true];
   }
 }
 
@@ -225,8 +225,9 @@ void ReportTestResult(XCTestCase *self, SEL _cmd) {
  * Each TestInfo (which represents an indivudal test method execution) is
  * translated into a method on the test case.
  *
- * @param The testing::TestCase of interest to translate.
- * @param A map of TestInfoKeys to testing::TestInfos, populated by this method.
+ * @param testCase The testing::TestCase of interest to translate.
+ * @param infoMap A map of TestInfoKeys to testing::TestInfos, populated by this
+ *     method.
  *
  * @return A new Class that's a subclass of XCTestCase, that's been registered
  * with the Objective-C runtime.
@@ -304,15 +305,15 @@ void RunGoogleTestTests() {
 
   // Convert XCTest's testToRun set to the equivalent --gtest_filter flag.
   //
-  // Note that we only set forceAllTests to YES if the user specifically focused
-  // on GoogleTests. This prevents XCTest double-counting test cases (and
-  // failures) when a user asks for all tests.
+  // Note that we only set forceAllTests to true if the user specifically
+  // focused on GoogleTests. This prevents XCTest double-counting test cases
+  // (and failures) when a user asks for all tests.
   NSSet<NSString *> *allTests = [NSSet setWithObject:masterTestCaseName];
   NSSet<NSString *> *testsToRun = LoadXCTestConfigurationTestsToRun();
   if (testsToRun) {
     if ([allTests isEqual:testsToRun]) {
       NSLog(@"Forcing all tests to run");
-      forceAllTests = YES;
+      forceAllTests = true;
     } else {
       NSString *filters = CreateTestFiltersFromTestsToRun(testsToRun);
       NSLog(@"Using --gtest_filter=%@", filters);